Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test which requires to be executed from an institutional account #253

Merged
merged 3 commits into from
Jul 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# Changelog

## [Unreleased](https://github.com/btschwertfeger/python-kraken-sdk/tree/HEAD)

[Full Changelog](https://github.com/btschwertfeger/python-kraken-sdk/compare/v3.0.0...HEAD)

Uncategorized merged pull requests:

- Bump actions/dependency-review-action from 4.3.3 to 4.3.4 [\#251](https://github.com/btschwertfeger/python-kraken-sdk/pull/251) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github/codeql-action from 3.25.11 to 3.25.12 [\#250](https://github.com/btschwertfeger/python-kraken-sdk/pull/250) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump actions/setup-python from 5.1.0 to 5.1.1 [\#249](https://github.com/btschwertfeger/python-kraken-sdk/pull/249) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump dependabot/fetch-metadata from 2.1.0 to 2.2.0 [\#248](https://github.com/btschwertfeger/python-kraken-sdk/pull/248) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump actions/download-artifact from 4.1.7 to 4.1.8 [\#247](https://github.com/btschwertfeger/python-kraken-sdk/pull/247) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github/codeql-action from 2.2.4 to 3.25.11 [\#246](https://github.com/btschwertfeger/python-kraken-sdk/pull/246) ([dependabot[bot]](https://github.com/apps/dependabot))
- CI: Change rules for harden-runner job in codeql [\#245](https://github.com/btschwertfeger/python-kraken-sdk/pull/245) ([btschwertfeger](https://github.com/btschwertfeger))
- Bump actions/dependency-review-action from 2.5.1 to 4.3.3 [\#243](https://github.com/btschwertfeger/python-kraken-sdk/pull/243) ([dependabot[bot]](https://github.com/apps/dependabot))

## [v3.0.0](https://github.com/btschwertfeger/python-kraken-sdk/tree/v3.0.0) (2024-06-23)

[Full Changelog](https://github.com/btschwertfeger/python-kraken-sdk/compare/v2.3.0...v3.0.0)

**Breaking changes:**

- Preparations - v3.0.0 [\#230](https://github.com/btschwertfeger/python-kraken-sdk/pull/230) ([btschwertfeger](https://github.com/btschwertfeger))

Uncategorized merged pull requests:

- Bump actions/checkout from 4.1.6 to 4.1.7 [\#241](https://github.com/btschwertfeger/python-kraken-sdk/pull/241) ([dependabot[bot]](https://github.com/apps/dependabot))

## [v2.3.0](https://github.com/btschwertfeger/python-kraken-sdk/tree/v2.3.0) (2024-06-10)

[Full Changelog](https://github.com/btschwertfeger/python-kraken-sdk/compare/v2.2.0...v2.3.0)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ import asyncio
from kraken.spot import SpotAsyncClient

async def main():
async with SpotAsyncClient(key="<your-api-key>", secret="<your-secret-key>")as client:
async with SpotAsyncClient(key="<your-api-key>", secret="<your-secret-key>") as client:
response = await client.request("POST", "/0/private/Balance")
print(response)

Expand Down
20 changes: 8 additions & 12 deletions tests/spot/test_spot_user.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@

import pytest

from kraken.exceptions import (
KrakenAuthenticationFailedError,
KrakenInvalidOrderError,
KrakenPermissionDeniedError,
)
from kraken.exceptions import KrakenInvalidOrderError, KrakenPermissionDeniedError
from kraken.spot import User

from .helper import is_not_error
Expand Down Expand Up @@ -420,6 +416,7 @@ def test_create_subaccount_failing(spot_auth_user: User) -> None:
@pytest.mark.spot()
@pytest.mark.spot_auth()
@pytest.mark.spot_user()
@pytest.mark.skip("Subaccount actions are only available for institutional clients")
def test_account_transfer_failing(spot_auth_user: User) -> None:
"""
Checks the ``account_transfer`` function by creating one.
Expand All @@ -430,10 +427,9 @@ def test_account_transfer_failing(spot_auth_user: User) -> None:

todo: test this using a valid account
"""
with pytest.raises(KrakenAuthenticationFailedError):
spot_auth_user.account_transfer(
asset="XBT",
amount=1.0,
from_="ABCD 1234 EFGH 5678",
to_="JKIL 9012 MNOP 3456",
)
spot_auth_user.account_transfer(
asset="XBT",
amount=1.0,
from_="ABCD 1234 EFGH 5678",
to_="JKIL 9012 MNOP 3456",
)
Loading