Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button #4606

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Update button #4606

merged 7 commits into from
Nov 1, 2024

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Oct 13, 2024

Closes #4407

Proposed Changes

image image

Clicking Learn what's new will open modal with release changes

image

Clicking Update Now will take you to downloads page.

Note: Release notes are not visible because the update behavior is being mocked.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@@ -100,7 +100,7 @@ export class ReportFeedback extends PureComponent {

return (
<Fragment>
<Fill slot="status-bar__app" group="9_feedback">
<Fill slot="status-bar__app" group="8_feedback">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change? It moves buttons around (on the status bar).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accomodate the new Update button

@lmbateman
Copy link

Visually it looks fine to me. Two minor points on the text:

  • The button says "Update", but the popup says "Upgrade". We should use the same word everywhere. If there's a difference between "update" and "upgrade", we should use the appropriate word (which I suspect is "update").
  • The Camunda style guide specifies sentence case, so in the popup, "Update Now" should be "Update now".

Thanks!

return (
<React.Fragment>
{updateAvailable && <Fill slot="status-bar__app" group="9_update_checks">
<button
style={ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using inline styles here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer element styles are inline (talking about Saved button and 💚 icon). I tried creating .less file to add styles initially, but it wasn't working so by looking at the reference buttons, I assumed it's not supposed to work this way. If we can eliminate the inline styles and use separate files for styles in Fill component, then we have to do it across all elements for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simply add a btn--primary class to StatusBar.less and use it for the button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. added a different class for Update button on StatusBar.less

@abdul99ahad abdul99ahad force-pushed the update-button branch 4 times, most recently from 8155f12 to 2733415 Compare October 21, 2024 09:51
@abdul99ahad
Copy link
Contributor Author

Ready for review

@abdul99ahad abdul99ahad force-pushed the update-button branch 2 times, most recently from 1fdbb68 to 508a1b8 Compare October 28, 2024 14:31
@philippfromme
Copy link
Contributor

Mac is finally passing. Will do the final review now.

Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a couple of small adjustments:

  • simplified CSS
  • adjusted naming for clarity
  • fixed whitespace

@philippfromme philippfromme merged commit fbdc36d into develop Nov 1, 2024
11 of 12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 1, 2024
@philippfromme philippfromme deleted the update-button branch November 1, 2024 12:06
@github-actions github-actions bot added this to the M83 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate that there is a new modeler version available
4 participants