-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update button #4606
Merged
Merged
Update button #4606
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b333efb
feat: update button
abdul99ahad ab7448e
test: update button
abdul99ahad 73b3af9
deps: update puppeteer to v23.6.1
philippfromme 4e5e94a
chore: whitespace
philippfromme a709a58
chore: simplify styling
philippfromme 3640470
chore: whitespace
philippfromme 6dcd4a5
chore: improve naming
philippfromme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
client/src/plugins/update-checks/UpdateAvailableOverlay.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/** | ||
* Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH | ||
* under one or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information regarding copyright | ||
* ownership. | ||
* | ||
* Camunda licenses this file to you under the MIT; you may not use this file | ||
* except in compliance with the MIT License. | ||
*/ | ||
|
||
import React from 'react'; | ||
|
||
import { Overlay, Section } from '../../shared/ui'; | ||
|
||
import * as css from './UpdateAvailableOverlay.less'; | ||
|
||
const OFFSET = { right: 0 }; | ||
|
||
export function UpdateAvailableOverlay(props) { | ||
return ( | ||
<Overlay id="update-available-overlay" | ||
anchor={ props.anchor } | ||
onClose={ props.onClose } | ||
offset={ OFFSET }> | ||
<UpdateAvailableSection | ||
version={ props.version } | ||
onOpenNewVersionInfoView={ props.onOpenNewVersionInfoView } | ||
onOpenDownloadUrl={ props.onOpenDownloadUrl } /> | ||
</Overlay> | ||
); | ||
} | ||
|
||
function UpdateAvailableSection(props) { | ||
const { | ||
onOpenDownloadUrl, | ||
onOpenNewVersionInfoView, | ||
version | ||
} = props; | ||
|
||
return ( | ||
<Section className={ css.UpdateAvailableOverlay } maxHeight="500px"> | ||
<Section.Header> | ||
Update available | ||
</Section.Header> | ||
<Section.Body> | ||
<p>Camunda Desktop Modeler {version} is available for use.</p> | ||
<a className="links" onClick={ onOpenDownloadUrl }>Update now</a> | ||
<a className="links" onClick={ onOpenNewVersionInfoView }>Learn what's new</a> | ||
</Section.Body> | ||
</Section> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:local(.UpdateAvailableOverlay) { | ||
|
||
.links { | ||
display: block; | ||
padding: 2px; | ||
cursor: pointer; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this change? It moves buttons around (on the status bar).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To accomodate the new
Update
button