Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2119 fix unknown error #1061

Merged
merged 2 commits into from
Dec 16, 2024
Merged

2119 fix unknown error #1061

merged 2 commits into from
Dec 16, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

We're setting the ReportSession's state to "started" as it is currently set to '', leading to "unknown errors" in Gazebo.

Links to relevant tickets

codecov/engineering-team#2119

@adrian-codecov adrian-codecov requested a review from a team as a code owner December 16, 2024 14:31
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@adrian-codecov adrian-codecov added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit e3b3e49 Dec 16, 2024
16 of 17 checks passed
@adrian-codecov adrian-codecov deleted the 2119-fix-unknown-error branch December 16, 2024 16:00
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (622b048) to head (863ab0f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
- Coverage   96.00%   95.76%   -0.25%     
==========================================
  Files         828      758      -70     
  Lines       19397    15008    -4389     
==========================================
- Hits        18623    14372    -4251     
+ Misses        774      636     -138     
Flag Coverage Δ
unit 92.27% <ø> (ø)
unit-latest-uploader 92.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants