Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow equal-signs in CFEP-25 pins #2167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

The original version of CFEP-25 used:

test:
  requires:
    - python ={{ python_min }}

This is a natural an allowed syntax in conda, as is

test:
  requires:
    - python =={{ python_min }}

We shouldn't spuriously lint on those, hence allow equal signs in the pattern.

@h-vetinari h-vetinari requested a review from a team as a code owner November 24, 2024 20:45
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed a smithy and conda build fix due to the equal signs. Once we have conda build 24.11 merged, let's retest before we merge this one.

@beckermr
Copy link
Member

@beckermr
Copy link
Member

This PR conda/conda-build#5555 fixes the issue (and I tested it live on a feedstock). We'll need to wait until 25.1.0 to see the fix live.

@h-vetinari
Copy link
Member Author

This PR conda/conda-build#5555 fixes the issue (and I tested it live on a feedstock). We'll need to wait until 25.1.0 to see the fix live.

Cool, thanks a lot! (and nice PR number! 😁)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants