Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow equal-signs in CFEP-25 pins #2167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

allow equal-signs in CFEP-25 pins #2167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd71f01
allow equal-signs in CFEP-25 pins
h-vetinari Nov 24, 2024
fbd0157
clean up an outdated lint w.r.t. CFEP-25
h-vetinari Nov 24, 2024
d017948
Merge branch 'main' into cfep25
beckermr Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conda_smithy/linter/hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def hint_noarch_python_use_python_min(
for section_name, syntax, report_syntax, reqs in [
(
"host",
r"python\s+{{ python_min }}",
r"python\s+=?=?{{ python_min }}",
"python {{ python_min }}",
host_reqs,
),
Expand All @@ -267,7 +267,7 @@ def hint_noarch_python_use_python_min(
),
(
"test.requires",
r"python\s+{{ python_min }}",
r"python\s+=?=?{{ python_min }}",
"python {{ python_min }}",
test_reqs,
),
Expand Down
5 changes: 3 additions & 2 deletions conda_smithy/linter/lints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,9 @@ def lint_require_lower_bound_on_python_version(
lints.append(
"noarch: python recipes are required to have a lower bound "
"on the python version. Typically this means putting "
"`python >=3.6` in **both** `host` and `run` but you should check "
"upstream for the package's Python compatibility."
"`python {{ python_min }}` in `host` and `python >={{ python_min }}` "
"in `run`. Please double-check upstream if the package already "
"requires an even newer Python version."
)


Expand Down
5 changes: 3 additions & 2 deletions tests/test_lint_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,8 +1641,9 @@ def test_noarch_python_bound(self):
expected_message = (
"noarch: python recipes are required to have a lower bound "
"on the python version. Typically this means putting "
"`python >=3.6` in **both** `host` and `run` but you should check "
"upstream for the package's Python compatibility."
"`python {{ python_min }}` in `host` and `python >={{ python_min }}` "
"in `run`. Please double-check upstream if the package already "
"requires an even newer Python version."
)
meta = {
"build": {"noarch": "python"},
Expand Down
Loading