Make Python 3.13 Compatible

[FlickerSoul]

This is currently a draft PR. See #72 (comment).

[edgarrmondragon]

I was working on

• Bump pyo3 to 0.21.2 #77

but if we can make the jump to pyo3 0.22 in this PR, I think that's preferable :)

[edgarrmondragon]

You need to add 3.13 to

rpds/.github/workflows/CI.yml

Lines 60 to 66 in 2fce424

	python-version: |
	3.8
	3.9
	3.10
	3.11
	3.12
	pypy3.10

[FlickerSoul]

@edgarrmondragon Thank you so much for the tips! I'll take a look at your PR tomorrow and can merge anything that can be added.

I'm not quite confident in my implementation. If you have time, it would be great to hear your ideas. Thanks!

[edgarrmondragon]

@edgarrmondragon Thank you so much for the tips! I'll take a look at your PR tomorrow and can merge anything that can be added.

I'm not quite confident in my implementation. If you have time, it would be great to hear your ideas. Thanks!

Changes look good to me, but I'm also not super familiar with pyo3' API (old or new) 😅. Maybe @davidhewitt can take a quick look in case something's majorly fumbled here.

[davidhewitt]

Broadly this looks correct to me 👍

[FlickerSoul]

@Julian Hi Julian, this PR should be ready for review. It bumps PyO3 to 0.22.1 and passes tests in Python 3.13 with GIL. However, it still breaks under the free-threaded Python. I'm happy to wait for updates from PyO3 and integrate so that rpds works on both variants of 3.13. What do you think?

[davidhewitt]

PyO3 will likely be a release or two before we support free-threaded Python properly, though it's very high priority on my TODO list.

I think probably we should be adjusting PyO3 to fail builds with a helpful error on free-threaded builds for the moment (maybe will release as 0.22.2). So I would advise not to wait for free-threaded support from us :)

[FlickerSoul]

@davidhewitt Thank you so much for your insight! I can submit a PR to allow PyO3 fail builds on free-threaded Python if that's helpful. :)

[Julian]

Thank you all for your help here, it's really appreciated! I'm going to merge I think. Thanks again!

[davidhewitt]

@davidhewitt Thank you so much for your insight! I can submit a PR to allow PyO3 fail builds on free-threaded Python if that's helpful. :)

@FlickerSoul a PR would be greatly appreciated. You'd need to modify pyo3-build-config to detect the freethreaded build and then emit an error similar to how we already check for supported Python versions.

[EwoutH]

6 minutes ago I added 3.13 to my CI setup and rpds was failing. Looked up the issues, saw 3 minutes ago rpds v0.19.0 was released, re-ran and it passed.

Awesome timing, and thanks a lot!