[azure-eventhub] Make the azure-eventhub input v1 tracer opt-in #41932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoog
added
enhancement
Team:obs-ds-hosted-services
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
| @@ -356,6 +356,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
| - Add evaluation state dump debugging option to CEL input. {pull}41335[41335] | |||
| - Added support for retry configuration in GCS input. {issue}11580[11580] {pull}41862[41862] | |||
| - Improve S3 polling mode states registry when using list prefix option. {pull}41869[41869] | |||
| - The environment variable `BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true` enables internal logs tracer for the azure-eventhub input. {issue}41931[41931] {pull}41932[41932] | |||
There was a problem hiding this comment.
should this variable be added to public documentation?
There was a problem hiding this comment.
Why I didn't think of it?! 🤦
Added!
zmoog
added
backport-8.16
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Kavindu-Dodan
approved these changes
Dec 6, 2024
zmoog
deleted the
zmoog/azure-eventhub-input-make-internal-logs-optional
branch
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f)
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f)
This was referenced Dec 6, 2024
Merged
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f)
Merged
8 tasks
zmoog
added a commit
that referenced
this pull request
Dec 6, 2024
…) (#41942) Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f) Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
zmoog
added a commit
that referenced
this pull request
Dec 6, 2024
…) (#41943) Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f) Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
zmoog
added a commit
that referenced
this pull request
Dec 6, 2024
…) (#41941) Make the `azure-eventhub` input v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable: ```sh BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: true ``` Before this change, the tracer was enabled by default. A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed. (cherry picked from commit 3b5823f) Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Make the
azure-eventhubinput v1 internal logs tracer opt-in. To enable internal (legacy) Event Hub SDK logs, now you need to set the following environment variable:BEATS_AZURE_EVENTHUB_INPUT_TRACING_ENABLED: trueBefore this change, the tracer was enabled by default.
A few customers reported higher than anticipated error logs in edge cases. These error logs are an essential signal to troubleshoot the root cause of several issues. However, we should give the option to completely opt out from the internal logs tracing when needed.
Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues