Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/core removal #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Chore/core removal #1

wants to merge 2 commits into from

Conversation

runspired
Copy link
Collaborator

This PR removes modules not related to velocity usage. For the most part, this is a seamless removal

  • Remove liquid-fire-core related modules
  • Fix imports/exports in remaining files to use core if needed
  • Supply animate function to liquid-fire-transitions

TODO:

  • Amend Demo Site (Should the demos stay here, or in ember-animation/liquid-fire?
  • Fix any tests that expected core / remove any tests that belong in core

Questions:

  • Is registering an animate function with a specific API on the liquid-fire-transitions service the way to approach liquid-fire-core's need for an animate function within Growable
  • Where does the velocity based demo site belong
  • Do we remove explode (this is not velocity backed, so where does it belong?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant