Enhance link checker and update bank data #525
Conversation
gstraccini
bot
added
☑️ auto-merge
WalkthroughThe pull request introduces modifications across several files, primarily focusing on the Changes
Possibly related issues
Possibly related PRs
Tip OpenAI O1 model for chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
gstraccini
bot
added
help wanted
github-actions
bot
added
the
size/S
penify-dev
bot
changed the title
![gstraccini[bot]](https://avatars.githubusercontent.com/in/480132?s=60&v=4){kind=small}
PR Review 🔍
|
PR Code Suggestions ✨
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -379,10 +379,10 @@ | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('599','36321990','36.321.990/0001-07','AGORACRED S/A SOCIEDADE DE CRÉDITO, FINANCIAMENTO E INVESTIMENTO','AGORACRED S/A SCFI',NULL,NULL,'RSFN',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-08-07',NULL,'2024-08-05T12:07:23.9850149+00:00','2024-08-05T12:07:23.9850339+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('600','59118133','59.118.133/0001-00','Banco Luso Brasileiro S.A.','BCO LUSO BRASILEIRO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Imobiliário,Pessoal,Veículos','https://bancoluso.com.br/','2002-04-22','2021-12-17 10:00:00','2021-05-05T09:11:12.7115232-03:00','2024-05-15T16:49:45.7318363+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('604','31895683','31.895.683/0001-16','Banco Industrial do Brasil S.A.','BCO INDUSTRIAL DO BRASIL S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Pessoal','https://www.bancoindustrial.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115033-03:00','2024-05-15T16:49:45.7304132+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('610','78626983','78.626.983/0001-63','Banco VR S.A.','BCO VR S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,NULL,'https://www.vrinvestimentos.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115452-03:00','2024-05-15T16:49:45.7376237+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('610','78626983','78.626.983/0001-63','Banco VR S.A.','BCO VR S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,NULL,NULL,'2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115452-03:00','2024-05-15T16:49:45.7376237+00:00'); | |||
Check warning
Code scanning / Tsqllint (reported by Codacy)
Object name not schema qualified Warning
| @@ -379,10 +379,10 @@ | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('599','36321990','36.321.990/0001-07','AGORACRED S/A SOCIEDADE DE CRÉDITO, FINANCIAMENTO E INVESTIMENTO','AGORACRED S/A SCFI',NULL,NULL,'RSFN',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-08-07',NULL,'2024-08-05T12:07:23.9850149+00:00','2024-08-05T12:07:23.9850339+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('600','59118133','59.118.133/0001-00','Banco Luso Brasileiro S.A.','BCO LUSO BRASILEIRO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Imobiliário,Pessoal,Veículos','https://bancoluso.com.br/','2002-04-22','2021-12-17 10:00:00','2021-05-05T09:11:12.7115232-03:00','2024-05-15T16:49:45.7318363+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('604','31895683','31.895.683/0001-16','Banco Industrial do Brasil S.A.','BCO INDUSTRIAL DO BRASIL S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Pessoal','https://www.bancoindustrial.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115033-03:00','2024-05-15T16:49:45.7304132+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('610','78626983','78.626.983/0001-63','Banco VR S.A.','BCO VR S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,NULL,'https://www.vrinvestimentos.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115452-03:00','2024-05-15T16:49:45.7376237+00:00'); | |||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('610','78626983','78.626.983/0001-63','Banco VR S.A.','BCO VR S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,NULL,NULL,'2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115452-03:00','2024-05-15T16:49:45.7376237+00:00'); | |||
Check warning
Code scanning / Tsqllint (reported by Codacy)
Use of unicode characters in a non unicode string Warning
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('611','61820817','61.820.817/0001-09','Banco Paulista S.A.','BCO PAULISTA S.A.','Banco Múltiplo',NULL,'RSFN',1,1,0,0,1,0,NULL,'Consignado,Imobiliário,Troca de Modalidade','https://www.bancopaulista.com.br','2002-04-22',NULL,'2021-05-05T09:11:12.7115321-03:00','2024-05-15T16:49:45.7335337+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('612','31880826','31.880.826/0001-16','Banco Guanabara S.A.','BCO GUANABARA S.A.','Banco Múltiplo','DRCT','RSFN',0,1,0,0,NULL,NULL,NULL,NULL,'https://www.bancoguanabara.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115029-03:00','2022-06-23T13:48:15.3478476+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos','https://www.bancopecunia.com.br','2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos',NULL,'2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00'); |
Check warning
Code scanning / Tsqllint (reported by Codacy)
Use of unicode characters in a non unicode string Warning
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('611','61820817','61.820.817/0001-09','Banco Paulista S.A.','BCO PAULISTA S.A.','Banco Múltiplo',NULL,'RSFN',1,1,0,0,1,0,NULL,'Consignado,Imobiliário,Troca de Modalidade','https://www.bancopaulista.com.br','2002-04-22',NULL,'2021-05-05T09:11:12.7115321-03:00','2024-05-15T16:49:45.7335337+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('612','31880826','31.880.826/0001-16','Banco Guanabara S.A.','BCO GUANABARA S.A.','Banco Múltiplo','DRCT','RSFN',0,1,0,0,NULL,NULL,NULL,NULL,'https://www.bancoguanabara.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115029-03:00','2022-06-23T13:48:15.3478476+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos','https://www.bancopecunia.com.br','2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00'); | ||
| INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos',NULL,'2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00'); |
Check warning
Code scanning / Tsqllint (reported by Codacy)
Object name not schema qualified Warning
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
data/bancos.sql (1)
Line range hint
1-385: Review SummaryThe series of INSERT statements for the
Bankstable look syntactically correct and mostly consistent with the AI summary. However, please note:
- The mentioned change for 'Omni Banco S.A.' is missing. Verify if this is an oversight and add the corresponding INSERT statement if required.
Other than that, the SQL statements appear properly structured with consistent field names and expected data formats. Just ensure the missing entry is accounted for.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
data/bancos.csvis excluded by!**/*.csv
Files selected for processing (4)
- .lycheeignore (1 hunks)
- data/bancos.json (2 hunks)
- data/bancos.md (1 hunks)
- data/bancos.sql (1 hunks)
Files skipped from review due to trivial changes (1)
- .lycheeignore
Additional context used
Markdownlint
data/bancos.md
387-387: null
Bare URL used(MD034, no-bare-urls)
388-388: null
Bare URL used(MD034, no-bare-urls)
Additional comments not posted (4)
data/bancos.md (2)
386-388: LGTM!The update to remove the URL for Banco VR S.A. looks good.
Tools
Markdownlint
387-387: null
Bare URL used(MD034, no-bare-urls)
388-388: null
Bare URL used(MD034, no-bare-urls)
389-389: LGTM!The update to remove the URL for Omni Banco S.A. looks good.
data/bancos.sql (2)
Line range hint
1-1: LGTM!The INSERT statement for 'Banco do Brasil S.A.' looks good. The
Urlfield is properly populated.
382-382: Matches AI summaryThe INSERT statement for 'Banco VR S.A.' has the
Urlfield set toNULL, which is consistent with the AI summary mentioning this change.
| @@ -9359,7 +9359,7 @@ | |||
| "Pessoal", | |||
| "Veículos" | |||
| ], | |||
| "Url": "https://www.bancopecunia.com.br", | |||
| "Url": null, | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Inconsistency found: URL present in XML but removed from JSON
The URL "https://www.bancopecunia.com.br" for Banco Pecunia was removed from the JSON file, but it still exists in the XML file (data/bancos.xml). This inconsistency needs to be addressed:
- Verify if the URL removal should be applied to all data representations (JSON and XML).
- Check if any part of the system relies on the XML data and might be affected by this inconsistency.
- Ensure that all references to Banco Pecunia are updated consistently across the codebase.
Analysis chain
Verify the impact of removing the URL.
The Url field for "Banco Pecunia" has been set to null, which is consistent with the change described in the AI-generated summary. This removes the web link associated with this bank.
Verify if any part of the system was relying on or referencing this specific Url value. Ensure its removal does not cause any breakage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if the removed URL is referenced anywhere in the codebase.
# Test: Search for the removed URL. Expect: No results.
rg --type-not json "https://www.bancopecunia.com.br" -A 5
Length of output: 458
| @@ -9282,7 +9282,7 @@ | |||
| "PCRP": true, | |||
| "SalaryPortability": null, | |||
| "Products": null, | |||
| "Url": "https://www.vrinvestimentos.com.br", | |||
| "Url": null, | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Synchronize URL data across JSON and XML formats
The removal of the URL for "VRI Investimentos" in the JSON file (data/bancos.json) is inconsistent with the data in the XML file (data/bancos.xml). Both files are listed in the project's README as official data sources, which makes this inconsistency a significant issue.
- The URL "https://www.vrinvestimentos.com.br" is still present in data/bancos.xml
- The URL has been set to null in data/bancos.json
Action items:
- Decide whether the URL should be removed or kept for "VRI Investimentos".
- Update both data/bancos.json and data/bancos.xml to ensure consistency.
- Review and update the process for modifying bank information to ensure all data formats (JSON, XML, and any others) are updated simultaneously.
- Check other entries in both files to ensure there are no other inconsistencies.
Analysis chain
Verify the impact of removing the URL.
The Url field for "VRI Investimentos" has been set to null, which is consistent with the change described in the AI-generated summary. This removes the web link associated with this bank.
Verify if any part of the system was relying on or referencing this specific Url value. Ensure its removal does not cause any breakage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if the removed URL is referenced anywhere in the codebase.
# Test: Search for the removed URL. Expect: No results.
rg --type-not json "https://www.vrinvestimentos.com.br" -A 5
Length of output: 464
Script:
#!/bin/bash
# Description: Search for references to bancos.xml and check for documentation
# Search for references to bancos.xml
echo "Searching for references to bancos.xml:"
rg "bancos\.xml" --type-not xml -A 5
# Check for README files that might explain the relationship between JSON and XML
echo -e "\nSearching for README files:"
fd -e md -e txt -e rst -e adoc README
Length of output: 700
Description
bancos.jsonto set URLs to null for certain banks.bancos.mdto reflect changes in bank URLs.bancos.sqlto ensure consistency with the updated data.Changes walkthrough 📝
.lycheeignore
Update link checker ignore list.lycheeignore
bancos.json
Update URLs in bancos.jsondata/bancos.json
bancos.sql
Update SQL for bank recordsdata/bancos.sql
bancos.md
Update bank documentationdata/bancos.md
Summary by CodeRabbit
New Features
.lycheeignorefile to include three new domains, improving the tool's efficiency by ignoring specified domains.Bug Fixes
Documentation
data/bancos.mdto reflect the removal of URLs for Banco VR S.A. and Omni Banco S.A., improving clarity in the documentation.