Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance link checker and update bank data #525

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Enhance link checker and update bank data #525

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
285ec74
Update .lycheeignore
guibranco Sep 14, 2024
ffce720
Update bancos.json
guibranco Sep 14, 2024
b5787c5
Update bancos.csv
guibranco Sep 14, 2024
55127f1
Update bancos.md
guibranco Sep 14, 2024
9fca3fd
Update bancos.json
guibranco Sep 14, 2024
db797c6
Update bancos.sql
guibranco Sep 14, 2024
47379c4
Update bancos.sql
guibranco Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .lycheeignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ rabobank\.com\.br
haitongib\.com\.br
xpi\.com\.br
bancopan\.com\.br
bancosemear\.com\.br
bancocedula\.com\.br
travelexbank\.com\.br
4 changes: 2 additions & 2 deletions data/bancos.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,10 @@
599,36321990,36.321.990/0001-07,AGORACRED S/A SOCIEDADE DE CRÉDITO FINANCIAMENTO E INVESTIMENTO,AGORACRED S/A SCFI,RSFN,,,,,Não,Não,,,,,,2024-08-07,,2024-08-05T12:07:23.9850149+00:00,2024-08-05T12:07:23.9850339+00:00
600,59118133,59.118.133/0001-00,Banco Luso Brasileiro S.A.,BCO LUSO BRASILEIRO S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Sim,,Consignado; Imobiliário; Pessoal; Veículos,https://bancoluso.com.br/,2002-04-22,2021-12-17 10:00:00,2021-05-05T09:11:12.7115232-03:00,2024-05-15T16:49:45.7318363+00:00
604,31895683,31.895.683/0001-16,Banco Industrial do Brasil S.A.,BCO INDUSTRIAL DO BRASIL S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Sim,,Consignado; Pessoal,https://www.bancoindustrial.com.br,2002-04-22,2020-11-03 06:30:00,2021-05-05T09:11:12.7115033-03:00,2024-05-15T16:49:45.7304132+00:00
610,78626983,78.626.983/0001-63,Banco VR S.A.,BCO VR S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Sim,,,https://www.vrinvestimentos.com.br,2002-04-22,2020-11-03 06:30:00,2021-05-05T09:11:12.7115452-03:00,2024-05-15T16:49:45.7376237+00:00
610,78626983,78.626.983/0001-63,Banco VR S.A.,BCO VR S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Sim,,,,2002-04-22,2020-11-03 06:30:00,2021-05-05T09:11:12.7115452-03:00,2024-05-15T16:49:45.7376237+00:00
611,61820817,61.820.817/0001-09,Banco Paulista S.A.,BCO PAULISTA S.A.,RSFN,Banco Múltiplo,,Sim,Sim,Não,Não,Sim,Não,,Consignado; Imobiliário; Troca de Modalidade,https://www.bancopaulista.com.br,2002-04-22,,2021-05-05T09:11:12.7115321-03:00,2024-05-15T16:49:45.7335337+00:00
612,31880826,31.880.826/0001-16,Banco Guanabara S.A.,BCO GUANABARA S.A.,RSFN,Banco Múltiplo,DRCT,Não,Sim,Não,Não,,,,,https://www.bancoguanabara.com.br,2002-04-22,2020-11-03 06:30:00,2021-05-05T09:11:12.7115029-03:00,2022-06-23T13:48:15.3478476+00:00
613,60850229,60.850.229/0001-47,Omni Banco S.A.,OMNI BANCO S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Não,,Outros Créditos; Pessoal; Veículos,https://www.bancopecunia.com.br,2002-04-22,2021-05-27 08:00:00,2021-05-05T09:11:12.7115268-03:00,2024-05-15T16:49:45.7485284+00:00
613,60850229,60.850.229/0001-47,Omni Banco S.A.,OMNI BANCO S.A.,RSFN,Banco Múltiplo,DRCT,Sim,Sim,Não,Não,Sim,Não,,Outros Créditos; Pessoal; Veículos,,2002-04-22,2021-05-27 08:00:00,2021-05-05T09:11:12.7115268-03:00,2024-05-15T16:49:45.7485284+00:00
614,52440987,52.440.987/0001-69,NITRO SOCIEDADE DE CRÉDITO DIRETO S.A.,NITRO SCD S.A.,RSFN,,,,,Não,Não,,,,,,2024-06-14,,2024-06-10T12:07:20.4287940+00:00,2024-06-10T12:07:20.4288223+00:00
619,49931906,49.931.906/0001-19,TRIO INSTITUICAO DE PAGAMENTO LTDA.,TRIO IP LTDA.,RSFN,,,,,Não,Não,,,,,,2024-08-01,,2024-07-26T12:29:30.1748074+00:00,2024-07-26T12:29:30.1748268+00:00
620,51342763,51.342.763/0001-51,REVOLUT SOCIEDADE DE CRÉDITO DIRETO S.A.,REVOLUT SCD S.A.,Internet,,,,,Não,Não,,,,,,2024-05-15,,2024-05-09T12:06:38.0036073+00:00,2024-05-09T12:06:38.0036074+00:00
Expand Down
4 changes: 2 additions & 2 deletions data/bancos.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9282,7 +9282,7 @@
"PCRP": true,
"SalaryPortability": null,
"Products": null,
"Url": "https://www.vrinvestimentos.com.br",
"Url": null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Synchronize URL data across JSON and XML formats

The removal of the URL for "VRI Investimentos" in the JSON file (data/bancos.json) is inconsistent with the data in the XML file (data/bancos.xml). Both files are listed in the project's README as official data sources, which makes this inconsistency a significant issue.

Action items:

  1. Decide whether the URL should be removed or kept for "VRI Investimentos".
  2. Update both data/bancos.json and data/bancos.xml to ensure consistency.
  3. Review and update the process for modifying bank information to ensure all data formats (JSON, XML, and any others) are updated simultaneously.
  4. Check other entries in both files to ensure there are no other inconsistencies.
Analysis chain

Verify the impact of removing the URL.

The Url field for "VRI Investimentos" has been set to null, which is consistent with the change described in the AI-generated summary. This removes the web link associated with this bank.

Verify if any part of the system was relying on or referencing this specific Url value. Ensure its removal does not cause any breakage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if the removed URL is referenced anywhere in the codebase.

# Test: Search for the removed URL. Expect: No results.
rg --type-not json "https://www.vrinvestimentos.com.br" -A 5

Length of output: 464

Script:

#!/bin/bash
# Description: Search for references to bancos.xml and check for documentation

# Search for references to bancos.xml
echo "Searching for references to bancos.xml:"
rg "bancos\.xml" --type-not xml -A 5

# Check for README files that might explain the relationship between JSON and XML
echo -e "\nSearching for README files:"
fd -e md -e txt -e rst -e adoc README

Length of output: 700

"DateOperationStarted": "2002-04-22",
"DatePixStarted": "2020-11-03 06:30:00",
"DateRegistered": "2021-05-05T09:11:12.7115452-03:00",
Expand Down Expand Up @@ -9359,7 +9359,7 @@
"Pessoal",
"Veículos"
],
"Url": "https://www.bancopecunia.com.br",
"Url": null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Inconsistency found: URL present in XML but removed from JSON

The URL "https://www.bancopecunia.com.br" for Banco Pecunia was removed from the JSON file, but it still exists in the XML file (data/bancos.xml). This inconsistency needs to be addressed:

  • Verify if the URL removal should be applied to all data representations (JSON and XML).
  • Check if any part of the system relies on the XML data and might be affected by this inconsistency.
  • Ensure that all references to Banco Pecunia are updated consistently across the codebase.
Analysis chain

Verify the impact of removing the URL.

The Url field for "Banco Pecunia" has been set to null, which is consistent with the change described in the AI-generated summary. This removes the web link associated with this bank.

Verify if any part of the system was relying on or referencing this specific Url value. Ensure its removal does not cause any breakage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if the removed URL is referenced anywhere in the codebase.

# Test: Search for the removed URL. Expect: No results. 
rg --type-not json "https://www.bancopecunia.com.br" -A 5

Length of output: 458

"DateOperationStarted": "2002-04-22",
"DatePixStarted": "2021-05-27 08:00:00",
"DateRegistered": "2021-05-05T09:11:12.7115268-03:00",
Expand Down
4 changes: 2 additions & 2 deletions data/bancos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ COMPE | ISPB | Document | Long Name | Short Name | Network | Type | PIX Type | C
599 | 36321990 | 36.321.990/0001-07 | AGORACRED S/A SOCIEDADE DE CRÉDITO, FINANCIAMENTO E INVESTIMENTO | AGORACRED S/A SCFI | RSFN | - | - | - | - | Não | Não | - | - | - | - | - | 2024-08-07 | - | 2024-08-05T12:07:23.9850149+00:00 | 2024-08-05T12:07:23.9850339+00:00
600 | 59118133 | 59.118.133/0001-00 | Banco Luso Brasileiro S.A. | BCO LUSO BRASILEIRO S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Sim | - | Consignado,Imobiliário,Pessoal,Veículos | https://bancoluso.com.br/ | 2002-04-22 | 2021-12-17 10:00:00 | 2021-05-05T09:11:12.7115232-03:00 | 2024-05-15T16:49:45.7318363+00:00
604 | 31895683 | 31.895.683/0001-16 | Banco Industrial do Brasil S.A. | BCO INDUSTRIAL DO BRASIL S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Sim | - | Consignado,Pessoal | https://www.bancoindustrial.com.br | 2002-04-22 | 2020-11-03 06:30:00 | 2021-05-05T09:11:12.7115033-03:00 | 2024-05-15T16:49:45.7304132+00:00
610 | 78626983 | 78.626.983/0001-63 | Banco VR S.A. | BCO VR S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Sim | - | - | https://www.vrinvestimentos.com.br | 2002-04-22 | 2020-11-03 06:30:00 | 2021-05-05T09:11:12.7115452-03:00 | 2024-05-15T16:49:45.7376237+00:00
610 | 78626983 | 78.626.983/0001-63 | Banco VR S.A. | BCO VR S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Sim | - | - | | 2002-04-22 | 2020-11-03 06:30:00 | 2021-05-05T09:11:12.7115452-03:00 | 2024-05-15T16:49:45.7376237+00:00
611 | 61820817 | 61.820.817/0001-09 | Banco Paulista S.A. | BCO PAULISTA S.A. | RSFN | Banco Múltiplo | - | Sim | Sim | Não | Não | Sim | Não | - | Consignado,Imobiliário,Troca de Modalidade | https://www.bancopaulista.com.br | 2002-04-22 | - | 2021-05-05T09:11:12.7115321-03:00 | 2024-05-15T16:49:45.7335337+00:00
612 | 31880826 | 31.880.826/0001-16 | Banco Guanabara S.A. | BCO GUANABARA S.A. | RSFN | Banco Múltiplo | DRCT | Não | Sim | Não | Não | - | - | - | - | https://www.bancoguanabara.com.br | 2002-04-22 | 2020-11-03 06:30:00 | 2021-05-05T09:11:12.7115029-03:00 | 2022-06-23T13:48:15.3478476+00:00
613 | 60850229 | 60.850.229/0001-47 | Omni Banco S.A. | OMNI BANCO S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Não | - | Outros Créditos,Pessoal,Veículos | https://www.bancopecunia.com.br | 2002-04-22 | 2021-05-27 08:00:00 | 2021-05-05T09:11:12.7115268-03:00 | 2024-05-15T16:49:45.7485284+00:00
613 | 60850229 | 60.850.229/0001-47 | Omni Banco S.A. | OMNI BANCO S.A. | RSFN | Banco Múltiplo | DRCT | Sim | Sim | Não | Não | Sim | Não | - | Outros Créditos,Pessoal,Veículos | | 2002-04-22 | 2021-05-27 08:00:00 | 2021-05-05T09:11:12.7115268-03:00 | 2024-05-15T16:49:45.7485284+00:00
614 | 52440987 | 52.440.987/0001-69 | NITRO SOCIEDADE DE CRÉDITO DIRETO S.A. | NITRO SCD S.A. | RSFN | - | - | - | - | Não | Não | - | - | - | - | - | 2024-06-14 | - | 2024-06-10T12:07:20.4287940+00:00 | 2024-06-10T12:07:20.4288223+00:00
619 | 49931906 | 49.931.906/0001-19 | TRIO INSTITUICAO DE PAGAMENTO LTDA. | TRIO IP LTDA. | RSFN | - | - | - | - | Não | Não | - | - | - | - | - | 2024-08-01 | - | 2024-07-26T12:29:30.1748074+00:00 | 2024-07-26T12:29:30.1748268+00:00
620 | 51342763 | 51.342.763/0001-51 | REVOLUT SOCIEDADE DE CRÉDITO DIRETO S.A. | REVOLUT SCD S.A. | Internet | - | - | - | - | Não | Não | - | - | - | - | - | 2024-05-15 | - | 2024-05-09T12:06:38.0036073+00:00 | 2024-05-09T12:06:38.0036074+00:00
Expand Down
2 changes: 1 addition & 1 deletion data/bancos.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,10 @@
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('599','36321990','36.321.990/0001-07','AGORACRED S/A SOCIEDADE DE CRÉDITO, FINANCIAMENTO E INVESTIMENTO','AGORACRED S/A SCFI',NULL,NULL,'RSFN',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-08-07',NULL,'2024-08-05T12:07:23.9850149+00:00','2024-08-05T12:07:23.9850339+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('600','59118133','59.118.133/0001-00','Banco Luso Brasileiro S.A.','BCO LUSO BRASILEIRO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Imobiliário,Pessoal,Veículos','https://bancoluso.com.br/','2002-04-22','2021-12-17 10:00:00','2021-05-05T09:11:12.7115232-03:00','2024-05-15T16:49:45.7318363+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('604','31895683','31.895.683/0001-16','Banco Industrial do Brasil S.A.','BCO INDUSTRIAL DO BRASIL S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,'Consignado,Pessoal','https://www.bancoindustrial.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115033-03:00','2024-05-15T16:49:45.7304132+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('610','78626983','78.626.983/0001-63','Banco VR S.A.','BCO VR S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,1,NULL,NULL,'https://www.vrinvestimentos.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115452-03:00','2024-05-15T16:49:45.7376237+00:00');

Check warning

Code scanning / Tsqllint (reported by Codacy)

Object name not schema qualified Warning

Object name not schema qualified

Check warning

Code scanning / Tsqllint (reported by Codacy)

Use of unicode characters in a non unicode string Warning

Use of unicode characters in a non unicode string
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('611','61820817','61.820.817/0001-09','Banco Paulista S.A.','BCO PAULISTA S.A.','Banco Múltiplo',NULL,'RSFN',1,1,0,0,1,0,NULL,'Consignado,Imobiliário,Troca de Modalidade','https://www.bancopaulista.com.br','2002-04-22',NULL,'2021-05-05T09:11:12.7115321-03:00','2024-05-15T16:49:45.7335337+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('612','31880826','31.880.826/0001-16','Banco Guanabara S.A.','BCO GUANABARA S.A.','Banco Múltiplo','DRCT','RSFN',0,1,0,0,NULL,NULL,NULL,NULL,'https://www.bancoguanabara.com.br','2002-04-22','2020-11-03 06:30:00','2021-05-05T09:11:12.7115029-03:00','2022-06-23T13:48:15.3478476+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos','https://www.bancopecunia.com.br','2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('613','60850229','60.850.229/0001-47','Omni Banco S.A.','OMNI BANCO S.A.','Banco Múltiplo','DRCT','RSFN',1,1,0,0,1,0,NULL,'Outros Créditos,Pessoal,Veículos',NULL,'2002-04-22','2021-05-27 08:00:00','2021-05-05T09:11:12.7115268-03:00','2024-05-15T16:49:45.7485284+00:00');

Check warning

Code scanning / Tsqllint (reported by Codacy)

Use of unicode characters in a non unicode string Warning

Use of unicode characters in a non unicode string

Check warning

Code scanning / Tsqllint (reported by Codacy)

Object name not schema qualified Warning

Object name not schema qualified
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('614','52440987','52.440.987/0001-69','NITRO SOCIEDADE DE CRÉDITO DIRETO S.A.','NITRO SCD S.A.',NULL,NULL,'RSFN',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-06-14',NULL,'2024-06-10T12:07:20.4287940+00:00','2024-06-10T12:07:20.4288223+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('619','49931906','49.931.906/0001-19','TRIO INSTITUICAO DE PAGAMENTO LTDA.','TRIO IP LTDA.',NULL,NULL,'RSFN',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-08-01',NULL,'2024-07-26T12:29:30.1748074+00:00','2024-07-26T12:29:30.1748268+00:00');
INSERT INTO Banks (COMPE,ISPB,Document,LongName,ShortName,Network,Type,PixType,Charge,CreditDocument,LegalCheque,DetectaFlow,PCR,PCRP,SalaryPortability,Products,Url,DateOperationStarted,DatePixStarted,DateRegistered,DateUpdated) VALUES('620','51342763','51.342.763/0001-51','REVOLUT SOCIEDADE DE CRÉDITO DIRETO S.A.','REVOLUT SCD S.A.',NULL,NULL,'Internet',NULL,NULL,0,0,NULL,NULL,NULL,NULL,NULL,'2024-05-15',NULL,'2024-05-09T12:06:38.0036073+00:00','2024-05-09T12:06:38.0036074+00:00');
Expand Down
Loading