Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize augments #661

Merged
merged 5 commits into from
May 29, 2024
Merged

Synchronize augments #661

merged 5 commits into from
May 29, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented May 25, 2024

kinda depends on auction sync, but not

this PR synchronizes

  • Portal extension (pos+rot of portal)
  • Trash uplink (explosion points)
    • works quite well now
    • ⚠️ not sure if this is necessary, only visual and should be similar
  • Position + direction of shots explicitly things work well w/o this!
    • as we can't rely on having the output be positioned and oriented the same on host and client
    • ⚠️ may require some extra safeguards in the future ™️
    • ⚠️ requires somewhat major refactor
  • Rubber sniper (possibly fixed by the above)

this PR seeds randomness to

  • Zigzag modifier (coil)
  • Trash uplink
  • Bullet projectiles (for angle)

this PR does not fix

  • shotgun madness on explosive barrel (check ondeath)
  • synced unplugging of tether
  • Flying platforms
    • ⚠️ this seems way harder than I thought :o

@toberge toberge force-pushed the feature/network-augments branch 9 times, most recently from 1902a98 to f9edb4e Compare May 26, 2024 18:36
@Fueredoriku Fueredoriku mentioned this pull request May 26, 2024
5 tasks
@toberge toberge force-pushed the feature/network-augments branch 11 times, most recently from 403e3a7 to 8e64814 Compare May 26, 2024 22:33
@toberge toberge force-pushed the feature/network-augments branch 2 times, most recently from d35df68 to 54ae8ea Compare May 26, 2024 22:40
@toberge toberge marked this pull request as ready for review May 26, 2024 22:43
@toberge toberge requested a review from Fueredoriku May 26, 2024 22:43
@toberge toberge force-pushed the feature/network-augments branch from 54ae8ea to 665bef2 Compare May 27, 2024 19:18
@toberge toberge mentioned this pull request May 28, 2024
11 tasks
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, ver nice work! 😎
Only thing I want to mention is that we no longer have "player 1" "player 2" etc, and just write "player" for everyone when playing localy. I think we should at least set up a new issue for this

Assets/Scripts/Augment/GunController.cs Outdated Show resolved Hide resolved
Assets/Scripts/Control&Input/Peer2PeerTransport.cs Outdated Show resolved Hide resolved
@toberge
Copy link
Contributor Author

toberge commented May 29, 2024

Seems to work, ver nice work! 😎 Only thing I want to mention is that we no longer have "player 1" "player 2" etc, and just write "player" for everyone when playing localy. I think we should at least set up a new issue for this

Regarding the player x problem, I'll likely deal with it in the #665 PR since I already started fixing problems with player select there

@toberge toberge force-pushed the feature/network-augments branch from 665bef2 to 06c2d88 Compare May 29, 2024 15:10
@toberge toberge merged commit 9066e9d into dev May 29, 2024
@toberge toberge deleted the feature/network-augments branch May 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants