Précision de la plateforme dans la conf docker-compose lvao #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolok
requested review from
fabienheureux and
maxcorbeau
and removed request for
a team
fabienheureux
requested changes
Nov 28, 2024
| @@ -20,6 +20,7 @@ x-airflow-common: | |||
| services: | |||
| lvao-db: | |||
| image: postgis/postgis:15-3.3-alpine | |||
| platform: linux/amd64 | |||
There was a problem hiding this comment.
Je sais pas si c'est une bonne idée, si l'image sort un jour la version ARM, on ne pourra en bénéficier.
Cf postgis/docker-postgis#216 ça semble dans les tuyaux...
Je serais donc d'avis de laisser ça là, avec le warning qui va bien.
Je l'ai depuis le début sur le projet, on s'y fait 😬
Et il est là pour une bonne raison à mon avis
There was a problem hiding this comment.
Au passage, un fork existe qui build avec arm en target https://github.com/baosystems/docker-postgis
On pourrait voir pour l'utiliser en attendant ? On gagnerait en perfs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Pour eviter le warning suivant :
@max.corbeau : Peux-tu vérifier si tu n'as pas d'alerte docker en
rebuildetups'il te plait ?Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :