Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Précision de la plateforme dans la conf docker-compose lvao #1087

Closed
wants to merge 1 commit into from
Closed

Précision de la plateforme dans la conf docker-compose lvao #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"filename": "docker-compose.yml",
"hashed_secret": "3cf2012487b086bba2adb3386d69c2ab67a268b6",
"is_verified": false,
"line_number": 39
"line_number": 40
}
],
"iframe_without_js.html": [
Expand Down Expand Up @@ -207,5 +207,5 @@
}
]
},
"generated_at": "2024-11-21T09:58:18Z"
"generated_at": "2024-11-28T17:01:19Z"
}
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ x-airflow-common:
services:
lvao-db:
image: postgis/postgis:15-3.3-alpine
platform: linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je sais pas si c'est une bonne idée, si l'image sort un jour la version ARM, on ne pourra en bénéficier.

Cf postgis/docker-postgis#216 ça semble dans les tuyaux...
Je serais donc d'avis de laisser ça là, avec le warning qui va bien.
Je l'ai depuis le début sur le projet, on s'y fait 😬

Et il est là pour une bonne raison à mon avis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au passage, un fork existe qui build avec arm en target https://github.com/baosystems/docker-postgis

On pourrait voir pour l'utiliser en attendant ? On gagnerait en perfs

environment:
- POSTGRES_USER=qfdmo
- POSTGRES_PASSWORD=qfdmo # pragma: allowlist secret
Expand Down
Loading