Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.10.x update to date #666

Merged
merged 223 commits into from
Dec 19, 2024
Merged

V0.10.x update to date #666

merged 223 commits into from
Dec 19, 2024

Conversation

isc-shuliu
Copy link
Collaborator

Merging changes from main (v0.9.x) branch

isc-tleavitt and others added 30 commits May 22, 2024 16:07
@isc-tleavitt
feat: support package mapping IPM everywhere
9b19985 
Even %SYS, but not using the %ALL namespace because that ends up overriding namespace-specific mappings (gah).
@isc-tleavitt
fix: reintroduce support for other types in PKG
68d311f 
Also adds tests, but it seems that this all just works.
@isc-tleavitt
fix: exotic resources can still publish deployed
2ce44ac 
If we have unit tests, exotic document types, etc., we won't hit <ILLEGAL VALUE> now.
@isc-tleavitt
test: minor sandbox changes
8ec85da 
Add git to container
Change to irishealth-community
Install 0.7.1 as a starting point
@isc-shuliu
fix: ignore case when checking for file existence
71c5cbf
@isc-shuliu
enhance: allow specifying pip/pip3 path
375e46c
@isc-shuliu
docs: add change log for ignore resource casing
97e7d3a
@isc-shuliu
docs: add change log for configuraing pip/pip3 path
3da4218
@isc-shuliu
enhance(pip): use python -m pip for installation as suggested by docs
e18f551
@isc-shuliu
fix: for windows, try locating irispip.exe before python.exe -m pip
e218304
@isc-shuliu
feat: add support for printing $listbuild(...) in universal config
8875973
@isc-shuliu
chore(ci): skip 2023.2 due to expired license
fb35d0d
@isc-shuliu
docs: add change log entries for pretty print config
d5ff185
@isc-shuliu
fix(ci): fix a bug when filtering packages
2e10191
@isc-shuliu
enhance(installer): attempt flexible python on windows
9f70be1
@isc-shuliu
fix: ensure CPF_PythonRuntimeLibrary is nonempty
990a0a1
@isc-shuliu
fix: auto detect pip caller unless specifically set
d57ecfb
@isc-shuliu
Revert "feat: add support for printing $listbuild(...) in universal c…
4f48a19 
…onfig"

This reverts commit 8875973.
@isc-shuliu
Revert "docs: add change log entries for pretty print config"
4868714 
This reverts commit d5ff185.
@isc-shuliu
style: remove unused classmethod ListToMultiDimensional
3ccd780
@isc-shuliu
fix: fix call to DetectPipCaller
8b8631a
@isc-shuliu
fix: pass pParams correctly to ResolvePipCaller
36ddc87
@isc-shuliu
style: remove postconditionals and use 1 command per line
df00e16
@isc-shuliu
docs: add parameter link in class referece
7c5cc6a
@isc-shuliu
fix: specify python version for wheel ABI compatibility
e74d835
@isc-tleavitt
Merge pull request #528 from intersystems/v1-fix-filepath-casing
170604b 
fix: ignore case when checking for file existence
@isc-tleavitt
fix: actually use irispip
bb6f029
@isc-shuliu
enhance: use existent RunCommand and better verbose settings
55fc337
@isc-tleavitt
Merge pull request #538 from intersystems/v1-fix-pip-path
dcf5a85 
enhance: allow specifying pip/pip3 path
@isc-shuliu
ci: trigger workflow on completion of packages test
c099b3a
@isc-shuliu
Copy link
Collaborator Author

The CIs are failing on GitHub but passing for me locally. Specifically, when migrating from ZPM 0.7, the zpm "list" command doesn't list zpm itself on GitHub while it does for me locally.

@isc-tleavitt
Copy link
Contributor

The CIs are failing on GitHub but passing for me locally. Specifically, when migrating from ZPM 0.7, the zpm "list" command doesn't list zpm itself on GitHub while it does for me locally.

@isc-shuliu it looks like we install zpm in %SYS. In that context, it shouldn't exist in USER.

@isc-shuliu
Copy link
Collaborator Author

It seems the legacy ZPM 0.7.x is always installed in %SYS but CIs were passing fine. https://github.com/intersystems/ipm/actions/runs/12380237397/job/34556166023#step:11:778

I'm guessing something in the migration logic changed this behavior.

@isc-shuliu
Copy link
Collaborator Author

@isc-tleavitt
What is the expected behavior when a user migrate from ZPM 0.7 (which is always installed in %SYS) to the latest IPM from another namespace, say USER? I know we should map IPM globally and migrate repo & module definitions.

But should we list the new 0.10.x zpm module in USER or %SYS?

@isc-shuliu isc-shuliu marked this pull request as ready for review December 18, 2024 19:32
@isc-shuliu isc-shuliu mentioned this pull request Dec 18, 2024
Open
@isc-tleavitt isc-tleavitt merged commit 0fb097d into v0.10.x Dec 19, 2024
12 checks passed
@isc-tleavitt
Copy link
Contributor

@isc-tleavitt What is the expected behavior when a user migrate from ZPM 0.7 (which is always installed in %SYS) to the latest IPM from another namespace, say USER? I know we should map IPM globally and migrate repo & module definitions.

But should we list the new 0.10.x zpm module in USER or %SYS?

We should list it wherever the installer was run.

@isc-shuliu isc-shuliu deleted the v0.10.x-update-to-date branch January 7, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-eneil isc-eneil isc-eneil approved these changes

@isc-kiyer isc-kiyer Awaiting requested review from isc-kiyer

@isc-tleavitt isc-tleavitt Awaiting requested review from isc-tleavitt

@isc-jili isc-jili Awaiting requested review from isc-jili

@isc-jlechtne isc-jlechtne Awaiting requested review from isc-jlechtne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@isc-shuliu @isc-tleavitt @isc-eneil @isc-kiyer @isc-jlechtne @bot