Add lightgun support to cocoa input driver #17318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The deprecated relative lightgun coordinates can be removed. I have not deleted them from other drivers, but the deprecation notice was added to libretro.h at least 6 years ago so nothing should be using it. Also, I believe it will not return correct value anyway (it should behave like a relative mouse, sending a delta since last query). Otherwise looks OK to me. |
drhelius
force-pushed
the
cocoa-lightgun
branch
from
0bb70bd to
a6dfca9
Compare
drhelius
force-pushed
the
cocoa-lightgun
branch
from
a6dfca9 to
76e4e08
Compare
|
Just removed deprecated relative lightgun coordinates and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current cocoa input driver does not support
RETRO_DEVICE_LIGHTGUN, thus MacOS and iOS can't control this device and cores must use an alternative likeRETRO_DEVICE_POINTER.This PR adds support for lightgun input to the cocoa input driver using an implementation similar to those found in
dinputandx11_inputdrivers.I was able to test it on macOS but not on iOS.
Reviewers
@warmenhoven @zoltanvb