Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add randomize data button to show issue when updating data #248

Closed
wants to merge 7 commits into from

Conversation

jpetitcolas
Copy link
Contributor

@jpetitcolas jpetitcolas commented Jul 5, 2018

When trying to update displayed data, we got an error:

bounds.js:10 Uncaught TypeError: Cannot read property 'length' of undefined

This PR adds a Randomize Data button on the demo to reproduce (and hopefully fix) the issue.

image

Fixes #247, fixes #246 and fixes #236.

@floo51
Copy link
Contributor

floo51 commented Jul 12, 2018

Refreshing data now works.

What's left to do:

  • Make zoom/scroll work
  • Make zoom not redraw everything
  • Make tests pass

@fzaninotto
Copy link
Member

Fixed by #262

@fzaninotto fzaninotto closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants