Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where the bounds end text disappeared. #262

Merged
merged 1 commit into from
Jan 5, 2019

Conversation

Busteren
Copy link
Contributor

@Busteren Busteren commented Jan 2, 2019

See commit for details. This fixes that the end text disappeared when scrolling/zooming.

This PR closes #240

Instead of two group with bounds, changed this to be one group where the text were added underneath the group in the DOM:
g
|- <text 'start'>
|- <text 'end'>

This fixes the issue where when only one drop line the end text would disappear when zooming.
@jpetitcolas
Copy link
Contributor

Thanks! It looks good, and it indeed fixes the issue. I'm not member of the core team anymore, but I'm sure someone like @ThieryMichel or @Kmaschta would be able to merge you. :)

@fzaninotto
Copy link
Member

@jpetitcolas I've added you back as a collaborator, you should be able to merge these changes.

@jpetitcolas
Copy link
Contributor

Thanks @fzaninotto! I'll ping you when a new version would be ready to publish on npm.

@jpetitcolas jpetitcolas merged commit df78e2f into marmelab:master Jan 5, 2019
@Busteren
Copy link
Contributor Author

Busteren commented Jan 24, 2019

I believe this actually fixes even more issues; When adding data, the bound used to throw an error, which I also encountered when trying to fix the bound issue. Today I had some spare time and remembered this, so I tested out adding a single data point to the data after a chart was created (which is something a lot of people have requested) and to my surprise, it worked!

Now I haven't done a lot of testing on it, but I think it would be good for other people to try it out and see if this sorts the problem. In the DEMO i just added

repositoriesData[2].fullData.push(data2);

With a drop that was in 2019 and sure enough it showed up (Yes I tried it twice, hence two drops here):
drop_update

If so this PR should close the following issues: #247 and #246
Should also close the following PR: #248

@jpetitcolas what do you think?

Edit:
only fixes part of #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small issue with scroll?
3 participants