Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: adds support for strict mode with OpenAI #9924

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

.Net: adds support for strict mode with OpenAI #9924

wants to merge 51 commits into from

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 10, 2024 •
edited
Loading

fixes #9786
closes #9741

eiriktsarpalis and others added 23 commits December 10, 2024 07:39
@eiriktsarpalis @baywet
Replace stj-schema-mapper source code with M.E.AI schema generation
d3d5edc
@baywet
feat: adds strict mode flag to function calling
535bd6e 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat: adds strict schema function behaviour and maps it to the metadata
ecc2cf8 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds unit test for additional properties false in strict mode
5ea8112 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds tests for tool call behaviour and strict mode
19e7cca 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds unit test for new function choice behaviour options property
9e780e5 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: cleanup reference to default
733fea9 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: badly formatted doc comment
6c32a37 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds test for function metadata to OAI function strict more ma…
a504d03 
…pping

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds validation for strict property mapping on OpenAIFunction
5b6d51a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: migrates to foreach
d6ca753 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds unit test for required properties behaviour with strict mode
4b111cb 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds test for metadata copy constructor
ef8de5d 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat: adds strict parameter to OpenAPI based functions
873ae6a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: pass strict when cloning function
dcaaa15 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
smell: having to set strict in the function prompt
8342d73 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: reverts additional strict property
1152c7a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: tests after strict property removal
5a2fae9 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: code linting
99aa4e0 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: makes schema less parameters optional in strict mode
4bbff9c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat; sanitizes forbidden strict mode keywords
34f887c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: adds missing null type in strict mode
dff7719 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
docs: add links to null type behaviour
f34ff32 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet requested a review from a team as a code owner December 10, 2024 12:40
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Dec 10, 2024
@github-actions github-actions bot changed the title adds support for strict mode with OpenAI .Net: adds support for strict mode with OpenAI Dec 10, 2024
@baywet baywet mentioned this pull request Dec 10, 2024
Closed
1 task
@baywet
docs: adds requested doc comments
b082a68 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds doc comment for static method
0f1d114 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: adds support for normalizing nested properties
e5c7a9d 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: normalizes additional properties
161b199 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: additional properties can be different types
1137aea 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: handles array types for additional properties normalization
167f4f4 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: makes all properties required
6a87dd6 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: enables strict mode for declarative agents
f5601b8 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: enables strict mode for CAPs and API plugins
43f1973 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: excludes forbidden default keyword
1630cdf 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes extraneous odata parameter filter
b8961c3 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: removes extraneous filter in api manifest extension
829812c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: parameter filter not being passed
652b3b8 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: a bug where rest api filters would only work for dynamic payload…
1b3004c 
… generation

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat: makes filtering properties available to the application
dcdbe46 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: adds properties trimming for CAPs demo
55ca088 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge branch 'feat/strict-mode' of https://github.com/baywet/semantic…
aa7856f 
…-kernel into feat/strict-mode
@baywet
Merge branch 'main' into feat/strict-mode
d59e70a
@baywet
fix: drive item test for CAPs
3b296e9 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@crickman crickman crickman left review comments

@dmytrostruk dmytrostruk dmytrostruk left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Extend function calling model to support strict mode
6 participants
@baywet @eiriktsarpalis @dmytrostruk @crickman @SergeyMenshykh @markwallace-microsoft