Remove dead code #4314
Draft
Remove dead code #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Dec 11, 2024
| @@ -88,36 +88,6 @@ internal static class Constants | |||
|
|
|||
| internal static readonly TestProperty InnerResultsCountProperty = TestProperty.Register("InnerResultsCount", InnerResultsCountLabel, typeof(int), TestPropertyAttributes.Hidden, typeof(TestResult)); | |||
|
|
|||
| internal static readonly TestProperty TestRunIdProperty = TestProperty.Register(TestRunId, TestRunId, typeof(int), TestPropertyAttributes.Hidden, typeof(TestCase)); | |||
There was a problem hiding this comment.
We never set a value for any of these properties. @Evangelink Could they be magically set by something else (not us)? Or is it really dead code?
Youssef1313
commented
Dec 11, 2024
| @@ -438,8 +438,7 @@ private void ExecuteTestsWithTestRunner( | |||
| PlatformServiceProvider.Instance.AdapterTraceLogger.LogInfo("Executing test {0}", unitTestElement.TestMethod.Name); | |||
|
|
|||
| // Run single test passing test context properties to it. | |||
| IDictionary<TestProperty, object?> tcmProperties = TcmTestPropertiesProvider.GetTcmProperties(currentTest); | |||
There was a problem hiding this comment.
This dictionary was always empty because we don't set TestCaseIdProperty anywhere, so GetTcmProperties returns an empty dictionary right away.
|
I sadly have no idea... Looks dead but I don't know. @nohwnd is it ringing any bell? |
|
all of them look azdo related (when it was still called tfs) microsoft/testfx-docs#36 #472 I would check with azdo team if they rely on these names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.