-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code #4314
Draft
Youssef1313
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
Youssef1313:dead-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove dead code #4314
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 0 additions & 50 deletions
50
src/Adapter/MSTest.TestAdapter/Execution/TcmTestPropertiesProvider.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -438,8 +438,7 @@ private void ExecuteTestsWithTestRunner( | |
PlatformServiceProvider.Instance.AdapterTraceLogger.LogInfo("Executing test {0}", unitTestElement.TestMethod.Name); | ||
|
||
// Run single test passing test context properties to it. | ||
IDictionary<TestProperty, object?> tcmProperties = TcmTestPropertiesProvider.GetTcmProperties(currentTest); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dictionary was always empty because we don't set |
||
Dictionary<string, object?> testContextProperties = GetTestContextProperties(tcmProperties, sourceLevelParameters); | ||
Dictionary<string, object?> testContextProperties = GetTestContextProperties(sourceLevelParameters); | ||
UnitTestResult[] unitTestResult = testRunner.RunSingleTest(unitTestElement.TestMethod, testContextProperties); | ||
|
||
PlatformServiceProvider.Instance.AdapterTraceLogger.LogInfo("Executed test {0}", unitTestElement.TestMethod.Name); | ||
|
@@ -479,21 +478,13 @@ private void ExecuteTestsWithTestRunner( | |
/// <summary> | ||
/// Get test context properties. | ||
/// </summary> | ||
/// <param name="tcmProperties">Tcm properties.</param> | ||
/// <param name="sourceLevelParameters">Source level parameters.</param> | ||
/// <returns>Test context properties.</returns> | ||
private static Dictionary<string, object?> GetTestContextProperties( | ||
IDictionary<TestProperty, object?> tcmProperties, | ||
IDictionary<string, object> sourceLevelParameters) | ||
{ | ||
var testContextProperties = new Dictionary<string, object?>(); | ||
|
||
// Add tcm properties. | ||
foreach (KeyValuePair<TestProperty, object?> propertyPair in tcmProperties) | ||
{ | ||
testContextProperties[propertyPair.Key.Id] = propertyPair.Value; | ||
} | ||
|
||
// Add source level parameters. | ||
foreach (KeyValuePair<string, object> propertyPair in sourceLevelParameters) | ||
{ | ||
|
241 changes: 0 additions & 241 deletions
241
test/UnitTests/MSTestAdapter.UnitTests/Execution/TcmTestPropertiesProviderTests.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never set a value for any of these properties. @Evangelink Could they be magically set by something else (not us)? Or is it really dead code?