ansible_mitogen: Templated connection timeout #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit (53b4881 in PR 1200) was not intended to change these values, but some WIP slipped through. This partially reverts that commit so the two changes (moving the monkey patch, making the monkey patch more capable) exist in distinct commits.
This will mitigate the impact of mitogen-hq#1185 a little, which causes the job to continue running without making progress, until it hits this timeout. Successful jobs are typically completing in 8 - 12 minutes. refs mitogen-hq#1185
moreati
force-pushed
the
issue1083-timeout
branch
from
f6f378e to
6900e88
Compare
moreati
force-pushed
the
issue1083-timeout
branch
25 times, most recently
from
29108f1 to
cbfaff9
Compare
moreati
force-pushed
the
issue1083-timeout
branch
3 times, most recently
from
8f25360 to
ebc5f4d
Compare
|
moreati
force-pushed
the
issue1083-timeout
branch
from
ebc5f4d to
984e05e
Compare
moreati
force-pushed
the
issue1083-timeout
branch
12 times, most recently
from
3fe01d7 to
19f45bd
Compare
Ansible >= 4 (ansible-core >= 2.11) the SSH plugin has a `timeout` option and with variable `ansible_ssh_timeout`, but not a `ansible_timeout` variable. The local plugin has no such option or variable(s). However `ansible_timeout` is backfilled for all conection plugins, by legacy mechanisms that populate the play context attribute: - `ansible.constants.COMMON_CONNECTION_VARS` - `ansible.constants.MAGIC_VARIABLE_MAPPING` The `timeout` keyword is for task completion timeout, not connection timeout.
moreati
force-pushed
the
issue1083-timeout
branch
from
19f45bd to
5e6d7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible >= 4 (ansible-core >= 2.11) the SSH plugin has a
timeoutoption and with variableansible_ssh_timeout, but not aansible_timeoutvariable. The local plugin has no such option or variable(s). Howeveransible_timeoutis backfilled for all conection plugins, by legacy mechanisms that populate the play context attribute:ansible.constants.COMMON_CONNECTION_VARSansible.constants.MAGIC_VARIABLE_MAPPINGThe
timeoutkeyword is for task completion timeout, not connection timeout.refs #1083