Replace dependabot automation action with groups feature #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Nov 3, 2023
| if: ${{ github.actor == 'dependabot[bot]' }} | ||
| steps: | ||
| - name: Enable Dependabot automation | ||
| uses: mozilla/syseng-pod/actions/dependabot-automerge@main |
There was a problem hiding this comment.
😢
Since Dev dependencies are not "deployed", shall we keep this automerge for them?
There was a problem hiding this comment.
We set up a dependabot group for all development dependencies so while it's not automatic, it's still fewer clicks.
I'm still overall wary about automatically merging code from a security perspective. Even running a compromised linting tool locally (for example) could pose a risk.
| groups: | ||
| production-dependency-patches: | ||
| dependency-type: "production" | ||
| update-types: ["patch"] |
There was a problem hiding this comment.
Here we group all patches together, but minor and major will get independent requests.
If we don't increase the schedule to "weekly", then there are less likely to be grouped, no?
There was a problem hiding this comment.
The schedule should remain weekly
leplatrem
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486