Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependabot automation action with groups feature #487

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Replace dependabot automation action with groups feature #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ updates:
interval: weekly
day: sunday
timezone: UCT
groups:
production-dependency-patches:
dependency-type: "production"
update-types: ["patch"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we group all patches together, but minor and major will get independent requests.

If we don't increase the schedule to "weekly", then there are less likely to be grouped, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schedule should remain weekly

development-dependencies:
dependency-type: "development"
update-types: ["major", "minor", "patch"]
open-pull-requests-limit: 99
reviewers:
- leplatrem
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,3 @@ jobs:

- name: Run browser tests
run: make browser-test

review-dependabot-pr:
permissions:
contents: write
pull-requests: write
runs-on: ubuntu-latest
if: ${{ github.actor == 'dependabot[bot]' }}
steps:
- name: Enable Dependabot automation
uses: mozilla/syseng-pod/actions/dependabot-automerge@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢
Since Dev dependencies are not "deployed", shall we keep this automerge for them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set up a dependabot group for all development dependencies so while it's not automatic, it's still fewer clicks.

I'm still overall wary about automatically merging code from a security perspective. Even running a compromised linting tool locally (for example) could pose a risk.

Loading