-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For the purposes of negative globs, treat them as positive globs. #67
Conversation
In Github you can define a "negative glob" aka, "not this path". To still validate this type of glob we simply check the opposite of that path.
Hi Kurtis, good catch. I've never used a negative glob myself, so I guess that's why they don't work. 😂 Clippy's got a bone to pick with you -- although I would have expected a regular build to fail, too, so I'll ponder what's going on there some other time. If you can add a couple of tests to the pile in |
Yeah I'm not sure what the problems here are, as all the documentation details this function as taking 2 arguments. |
…replace is called? This is my second line of rust code ever written.
oh, lol there's a replace function on |
Thanks for the updates, Kurtis. I'll get onto this by next week, I promise. 🤞 |
@mpalmer Any chance you could run the actions? |
Sorry, I thought once I'd approved them once they'd be run automatically thereafter. TIL... |
I created a second PR, #71, based on yours, and fixed up a few things. It's now merged, so we can consider this done, I reckon. Thanks for your work to make it happen! |
In Github you can define a "negative glob" aka, "not this path". To still validate this type of glob we simply check the opposite of that path.