Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative globs, take 2 #71

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Negative globs, take 2 #71

merged 6 commits into from
Jan 30, 2024

Conversation

mpalmer
Copy link
Owner

@mpalmer mpalmer commented Jan 30, 2024

Supercedes #67.

krainboltgreene and others added 6 commits January 5, 2024 12:50
@krainboltgreene
For the purposes of negative globs, treat them as positive globs.
5936f79 
In Github you can define a "negative glob" aka, "not this path". To still validate this type of glob we simply check the opposite of that path.
@krainboltgreene
Maybe g.as_str() returns something that needs to be unwrapped before …
d70b359 
…replace is called?

This is my second line of rust code ever written.
@krainboltgreene
Adding a negative glob for testing
3828eca
@krainboltgreene
I have no idea what I'm doing
91ad200
@mpalmer
Fix+augment testsuite, tighten up implementation
477ed17
@mpalmer
Fix nightly build error
9b96cbe
@mpalmer mpalmer merged commit 01e87d5 into main Jan 30, 2024
16 checks passed
@mpalmer mpalmer mentioned this pull request Jan 30, 2024
Merged
@mpalmer mpalmer deleted the negative-globs branch February 9, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpalmer @krainboltgreene