Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kpt alpha to use porchctl #110

Closed
wants to merge 0 commits into from

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Feb 7, 2024

No description provided.

@efiacor
Copy link
Contributor Author

efiacor commented Feb 7, 2024

Copy link
Contributor

nephio-prow bot commented Feb 7, 2024

@efiacor: GitHub didn't allow me to assign the following users: CsatariGergely.

Note that only nephio-project members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @CsatariGergely @liamfallon @lapentad @arora-sagar @tliron @gvbalaji

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Feb 7, 2024
@liamfallon
Copy link
Member

Will wait for some more "approves" before doing a "lgtm"

@liamfallon
Copy link
Member

It'd be good to get one more /approve on this

@electrocucaracha
Copy link
Member

@efiacor it seems like there is a rebase conflict on this PR, and could you include a porchctl as part of the prerequisites?

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 3f24ac2
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/65ce9704c57bf500083248b4
😎 Deploy Preview https://deploy-preview-110--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@efiacor
Copy link
Contributor Author

efiacor commented Feb 15, 2024

@efiacor it seems like there is a rebase conflict on this PR, and could you include a porchctl as part of the prerequisites?

Done. I will need to update the porch docs to include an install guide asap. Linked to the release page on gh for now. We also need to do an official release as it is still in pre release state.

@efiacor efiacor closed this Feb 15, 2024
@efiacor efiacor force-pushed the update_to_use_porchctl branch from e44d551 to 3f24ac2 Compare February 15, 2024 22:58
Copy link
Contributor

nephio-prow bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot removed the approved label Feb 15, 2024
@efiacor efiacor deleted the update_to_use_porchctl branch February 15, 2024 22:59
@efiacor efiacor restored the update_to_use_porchctl branch February 15, 2024 23:06
@efiacor efiacor deleted the update_to_use_porchctl branch February 15, 2024 23:15
nephio-prow bot pushed a commit that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants