Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiphase - new module #6854

Merged
merged 44 commits into from
Nov 7, 2024
Merged

Hiphase - new module #6854

merged 44 commits into from
Nov 7, 2024

Conversation

tanyasarkjain
Copy link
Contributor

@tanyasarkjain tanyasarkjain commented Oct 25, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@tanyasarkjain tanyasarkjain changed the title Hiphase Hiphase - new module Oct 25, 2024
@tanyasarkjain tanyasarkjain self-assigned this Oct 25, 2024
@tanyasarkjain tanyasarkjain removed their assignment Oct 25, 2024
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the indexes should be with the corresponding files, not a separate tuple.

modules/nf-core/hiphase/main.nf Outdated Show resolved Hide resolved
modules/nf-core/hiphase/main.nf Outdated Show resolved Hide resolved
modules/nf-core/hiphase/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/hiphase/meta.yml Outdated Show resolved Hide resolved
tanyasarkjain and others added 4 commits November 5, 2024 16:11
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@tanyasarkjain
Copy link
Contributor Author

I think that the indexes should be with the corresponding files, not a separate tuple.

okay - I changed the input structure to 3-value tuples

@tanyasarkjain
Copy link
Contributor Author

should have resolved all your comments!

@sateeshperi sateeshperi enabled auto-merge November 7, 2024 06:27
@sateeshperi sateeshperi added this pull request to the merge queue Nov 7, 2024
Merged via the queue into nf-core:master with commit d29fcb4 Nov 7, 2024
12 checks passed
@fellen31 fellen31 mentioned this pull request Nov 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants