Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: doubletdetection #6897

Merged
merged 17 commits into from
Nov 4, 2024
Merged

Conversation

LeonHafner
Copy link
Contributor

@LeonHafner LeonHafner commented Oct 29, 2024

PR checklist

  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label

@LeonHafner LeonHafner added new module Adding a new module draft labels Oct 29, 2024
@LeonHafner
Copy link
Contributor Author

This module does not support conda, as the bioconda doubletdetection build is not working properly.

@LeonHafner LeonHafner marked this pull request as ready for review November 1, 2024 08:41
@LeonHafner LeonHafner requested a review from a team as a code owner November 1, 2024 08:41
Copy link
Contributor

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonHafner LeonHafner added this pull request to the merge queue Nov 4, 2024
Merged via the queue into nf-core:master with commit 3dc1bb8 Nov 4, 2024
11 checks passed
@LeonHafner LeonHafner deleted the doubletdetection branch November 4, 2024 15:44
@edmundmiller
Copy link
Contributor

edmundmiller commented Nov 14, 2024

Hey @LeonHafner how did it get built by Seqera containers then? What's was in the environment.yml?

Was it

channels:
  - conda-forge
  - bioconda
dependencies:
  - conda-forge::anndata=0.10.7
  - conda-forge::louvain=0.8.2
  - bioconda::doubletdetection=4.2

@LeonHafner
Copy link
Contributor Author

Hey @edmundmiller,
the Seqera containers are built using the doubletdetection package via pip. However, nf-core linting doesn’t allow pip dependencies in the environment.yml. To address this, I added the package to Bioconda, but after some painful hours of debugging and trying to match the versions with the containers, it turned out the Bioconda version is broken and isn’t working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create nf-core module for DoubletDetection
3 participants