Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CENTRIFUGE: bump versions, fix missing args, and command formatting #7205

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Dec 12, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133 jfy133 marked this pull request as ready for review December 12, 2024 09:50
modules/nf-core/centrifuge/build/main.nf Show resolved Hide resolved
modules/nf-core/centrifuge/centrifuge/main.nf Show resolved Hide resolved
sateeshperi
sateeshperi previously approved these changes Dec 12, 2024
@sateeshperi sateeshperi requested a review from a team as a code owner December 13, 2024 07:23
@jfy133 jfy133 dismissed stale reviews from LilyAnderssonLee and sateeshperi via 28de288 December 13, 2024 17:48
@jfy133 jfy133 requested a review from sateeshperi December 19, 2024 11:39
matthdsm
matthdsm previously approved these changes Dec 19, 2024
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sateeshperi sateeshperi merged commit 8581a56 into master Dec 19, 2024
24 checks passed
@sateeshperi sateeshperi deleted the update-centrifuge-version branch December 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants