Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prokka to take compressed input && tidy module script #7250

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Dec 19, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@prototaxites
Copy link
Contributor Author

prototaxites commented Dec 19, 2024

Undoing container build bump - there's some kind of java version error with minced that I'm getting when running with Singularity on our HPC (but not on Gitpod).

See tseemann/prokka#557 for details - bumped container image has a version of java that's too new:

Original image:

╰λ singularity shell $NXF_SINGULARITY_CACHEDIR/depot.galaxyproject.org-singularity-prokka-1.14.6--pl5321hdfd78af_4.img 
Singularity> java --version
openjdk 11.0.9.1-internal 2020-11-04
OpenJDK Runtime Environment (build 11.0.9.1-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 11.0.9.1-internal+0-adhoc..src, mixed mode)
Singularity> exit

Bumped image:

╰λ singularity shell $NXF_SINGULARITY_CACHEDIR/depot.galaxyproject.org-singularity-prokka-1.14.6--pl5321hdfd78af_5.img 
Singularity> java --version
openjdk 20.0.2-internal 2023-07-18
OpenJDK Runtime Environment (build 20.0.2-internal-adhoc..src)
OpenJDK 64-Bit Server VM (build 20.0.2-internal-adhoc..src, mixed mode, sharing)

@prototaxites
Copy link
Contributor Author

The minced binary is built with Java version 8 - I've switched the container to a Sequera container with the correct OpenJDK version pinned, and updated the Conda environment to match.

Testing seems to have fixed the problem on our cluster; hopefully will fix this intermittently reported issue in mag too: nf-core/mag#552

Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jim,

Supporting gzipped input is a nice adittion to have. And thank you for looking into the issues when running Prokka, because sometimes becomes mysteriously unreliable for some reason.

Aside from the minor changes I proposed, if you have time, can you please add the stub and the stub test?

Thank you.

modules/nf-core/prokka/main.nf Outdated Show resolved Hide resolved
modules/nf-core/prokka/main.nf Outdated Show resolved Hide resolved
modules/nf-core/prokka/main.nf Outdated Show resolved Hide resolved
@prototaxites
Copy link
Contributor Author

Added stub & corresponding test.

If anyone knows how to convert the oras:// identifier to https://, please let me know!

Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it's ready to merge then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants