-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prokka to take compressed input && tidy module script #7250
base: master
Are you sure you want to change the base?
Conversation
Undoing container build bump - there's some kind of java version error with minced that I'm getting when running with Singularity on our HPC (but not on Gitpod). See tseemann/prokka#557 for details - bumped container image has a version of java that's too new: Original image:
Bumped image:
|
The minced binary is built with Java version 8 - I've switched the container to a Sequera container with the correct OpenJDK version pinned, and updated the Conda environment to match. Testing seems to have fixed the problem on our cluster; hopefully will fix this intermittently reported issue in mag too: nf-core/mag#552 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jim,
Supporting gzipped input is a nice adittion to have. And thank you for looking into the issues when running Prokka, because sometimes becomes mysteriously unreliable for some reason.
Aside from the minor changes I proposed, if you have time, can you please add the stub and the stub test?
Thank you.
Added stub & corresponding test. If anyone knows how to convert the oras:// identifier to https://, please let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, it's ready to merge then!
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda