Fix build #147
Open
Fix build #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're changing way too many things at once.
You should at least put such changes in separate commit to make the diff more digest. |
|
Yes, I will split it. |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
|
Gentle ping |
hhugo
reviewed
Dec 18, 2024
| (depends | ||
| (ocaml (< 5.0)) |
There was a problem hiding this comment.
This seem to be the only significant change in this large diff. Why is it not compatible with ocaml 5 ? It would be more useful to fix the build. The rest of changes don't seem related to fixing the build. I don't understand the motivation behind all this.
|
Looking at the CI, the build doesn't seem to be broken. https://github.com/ocsigen/html_of_wiki/actions/runs/12344711217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix build.