Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Main workflow
name: Builds, tests & co

on:
pull_request:
push:
pull_request:
schedule:
# Prime the caches every Monday
- cron: 0 1 * * MON
Expand All @@ -13,60 +13,49 @@ jobs:
fail-fast: false
matrix:
os:
- macos-latest
- ubuntu-latest
- macos-latest
- windows-latest

runs-on: ${{ matrix.os }}

steps:
- name: Checkout tree
uses: actions/checkout@v4

- name: Set-up OCaml
uses: ocaml/setup-ocaml@v3
with:
ocaml-compiler: "4.14"

- run: opam install . --deps-only

- run: opam exec -- make all

lint-doc:
runs-on: ubuntu-latest
steps:
- name: Checkout tree
uses: actions/checkout@v4

- name: Set-up OCaml
uses: ocaml/setup-ocaml@v3
with:
ocaml-compiler: "4.14"

- uses: ocaml/setup-ocaml/lint-doc@v3

lint-fmt:
runs-on: ubuntu-latest
steps:
- name: Checkout tree
uses: actions/checkout@v4

- name: Set-up OCaml
uses: ocaml/setup-ocaml@v3
with:
ocaml-compiler: "4.14"

- uses: ocaml/setup-ocaml/lint-fmt@v3

lint-opam:
runs-on: ubuntu-latest
steps:
- name: Checkout tree
uses: actions/checkout@v4

- name: Set-up OCaml
uses: ocaml/setup-ocaml@v3
with:
ocaml-compiler: "4.14"

- uses: ocaml/setup-ocaml/lint-opam@v3
35 changes: 10 additions & 25 deletions dune-project
Original file line number Diff line number Diff line change
@@ -1,41 +1,26 @@
(lang dune 2.0)

(using menhir 2.0)

(lang dune 3.17)
(name html_of_wiki)

(generate_opam_files true)
(implicit_transitive_deps false)

(license "LGPL-2.1 with OCaml linking exception")

(authors "The ocsigen team <dev@ocsigen.org>")

(maintainers
"The ocsigen team <dev@ocsigen.org>"
"Leo Valais <leo.valais97@gmail.com>")

(source
(github ocsigen/html_of_wiki))

(bug_reports "https://github.com/ocsigen/html_of_wiki/issues")

(homepage "https://github.com/ocsigen/html_of_wiki")

(maintainers "The ocsigen team <dev@ocsigen.org>" "Leo Valais <leo.valais97@gmail.com>")
(source (github ocsigen/html_of_wiki))
(documentation "https://ocsigen.org/html_of_wiki/2.0/manual/intro")

(generate_opam_files true)

(package
(name html_of_wiki)
(synopsis "A wikicreole to HTML compiler")
(description
"a static website generator for software projects, using wikicreole syntax.")
(description "a static website generator for software projects, using wikicreole syntax.")
(depends
(ocaml (< 5.0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to be the only significant change in this large diff. Why is it not compatible with ocaml 5 ? It would be more useful to fix the build. The rest of changes don't seem related to fixing the build. I don't understand the motivation behind all this.

("cmdliner" (>= 1.1.1))
"js_of_ocaml-ppx_deriving_json"
("tyxml"(>= 4.6.0))
"base64"
"js_of_ocaml-ppx"
"js_of_ocaml-ppx_deriving_json"
"ocamlfind"
"re"
"base64"
"reason"
("tyxml"(>= 4.6.0))))
"reason"))
12 changes: 7 additions & 5 deletions html_of_wiki.opam
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,20 @@ homepage: "https://github.com/ocsigen/html_of_wiki"
doc: "https://ocsigen.org/html_of_wiki/2.0/manual/intro"
bug-reports: "https://github.com/ocsigen/html_of_wiki/issues"
depends: [
"dune" {>= "2.0"}
"dune" {>= "3.17"}
"ocaml" {< "5.0"}
"cmdliner" {>= "1.1.1"}
"js_of_ocaml-ppx_deriving_json"
"tyxml" {>= "4.6.0"}
"base64"
"js_of_ocaml-ppx"
"js_of_ocaml-ppx_deriving_json"
"ocamlfind"
"re"
"base64"
"reason"
"tyxml" {>= "4.6.0"}
"odoc" {with-doc}
]
build: [
["dune" "subst"] {pinned}
["dune" "subst"] {dev}
[
"dune"
"build"
Expand Down