Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty lines after rewrite #300

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Remove empty lines after rewrite #300

merged 11 commits into from
Jun 7, 2024

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Jun 4, 2024

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@koppor
Copy link
Contributor Author

koppor commented Jun 4, 2024

I left all commits, because there will be a squash-merge, won't it?

@timtebeek timtebeek self-requested a review June 4, 2024 13:02
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Jun 4, 2024
@koppor
Copy link
Contributor Author

koppor commented Jun 4, 2024

I did not see #190 while implementing. Think, my code is shorter then the one suggested at #190.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking this on! #190 had indeed lingered as there were a lot of formatting changes, making it a challenge to review. That earlier PR did have explicit tests for @throws and @return, which seem to have been removed here. Should any of that make it in here?

I'm inclined to proceed with this PR, as I like the minimal approach you took at making changes, such that it's easier to spot what goes into removing empty lines. Let's get the comments resolved and get this fix in.

@timtebeek timtebeek merged commit 667ee47 into openrewrite:main Jun 7, 2024
2 checks passed
@koppor koppor deleted the fix-119 branch June 7, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
2 participants