-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty lines after rewrite #300
Conversation
I left all commits, because there will be a squash-merge, won't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking this on! #190 had indeed lingered as there were a lot of formatting changes, making it a challenge to review. That earlier PR did have explicit tests for @throws
and @return
, which seem to have been removed here. Should any of that make it in here?
I'm inclined to proceed with this PR, as I like the minimal approach you took at making changes, such that it's easier to spot what goes into removing empty lines. Let's get the comments resolved and get this fix in.
Checklist