Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Revert" wording format should not count on character limit check #51

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

michaelgrifalconi
Copy link
Contributor

Right now, using Revert feature in UI or committing manually something with "Revert" word in addition, may trigger the check and block the merge of a time critical fix.

Example of issue: https://github.com/os-autoinst/os-autoinst-distri-opensuse/actions/runs/8076696536/job/22065582052

I try to allow both cases, with quoted commit (default from UI) and a manual commit that only adds Revert word and a space.

  • Allow: <72chars>
  • Allow: Revert<72char>
  • Allow: Revert"<72char>" -> This is default format to revert using UI
  • Do not allow: "<72char>"

Can be checked at https://regex101.com/

For your convenience, here are 72 chars for testing:

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

- Allow: <72chars>
- Allow: Revert<SPACE><72char>
- Allow: Revert<SPACE>"<72char>"  -> This is default format to revert using UI
- Do not allow: "<72char>"
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

.github/workflows/base-commit-message-checker.yml Outdated Show resolved Hide resolved
Co-authored-by: Oliver Kurz <okurz@suse.de>
@mergify mergify bot merged commit 3b775e7 into os-autoinst:master Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants