Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown am Split-Button wird abgeschnitten #6725

Closed
laske185 opened this issue Aug 12, 2024 · 3 comments · Fixed by #6726
Closed

Dropdown am Split-Button wird abgeschnitten #6725

laske185 opened this issue Aug 12, 2024 · 3 comments · Fixed by #6726
Assignees
@anicyne @Makko74
Labels
bug Something isn't working

Comments

@laske185
Copy link
Contributor

Ist der Dropdown innerhalb einer Komponente mit Shadow-DOM (Bsp.: KolCard), wird das Dropdown abgeschnitten, wenn es hinausragen würde.

Image
@laske185 laske185 converted this from a draft issue Aug 12, 2024
@laske185 laske185 added the bug Something isn't working label Aug 12, 2024
@laske185
Copy link
Contributor Author

Lösungsansatz: Der innere Container des Popover muss statt position: absolute auf position: fixed umgestellt werden. Dafür muss die Position allerdings berechnet werden. Hierfür kann die gleiche Lib und Ansatz wie im Tooltip verwendet werden.

@laske185 laske185 mentioned this issue Aug 12, 2024
Open
@anicyne anicyne self-assigned this Aug 12, 2024
@anicyne anicyne moved this from Backlog to 📄 Ready in KoliBri Board Aug 12, 2024
@laske185
Copy link
Contributor Author

laske185 commented Aug 12, 2024 •
edited
Loading

Statt dem:

<div class="popover" ref={this.catchDropdownElements}>
	<div class="popover-content">
		<slot />
	</div>
</div>

sollte

<KolPopoverWc>
    <slot />
</KolPopoverWc>

verwendet werden.

anicyne added a commit that referenced this issue Aug 12, 2024
@anicyne
Replace dropdown with kolPopoverWc in Split-Button
35be7c0 
Refs: #6725
@anicyne anicyne linked a pull request Aug 12, 2024 that will close this issue
Replace kolSelect with split button in pagination #6721
Closed
@anicyne anicyne removed a link to a pull request Aug 12, 2024
Replace kolSelect with split button in pagination #6721
Closed
@anicyne anicyne mentioned this issue Aug 12, 2024
Merged
@anicyne anicyne linked a pull request Aug 12, 2024 that will close this issue
Replace dropdown with kolPopoverWc in Split-Button #6726
Merged
anicyne added a commit that referenced this issue Aug 13, 2024
@anicyne
Replace position absolute with fixed
f145ad4 
Refs: #6725
anicyne added a commit that referenced this issue Aug 13, 2024
@anicyne
Fix Popover test
a3a87af 
Refs: #6725
anicyne added a commit that referenced this issue Aug 13, 2024
@anicyne
Fix popover css
e1cf6bd 
Refs: #6725
anicyne added a commit that referenced this issue Aug 14, 2024
@anicyne
fix: correct popover style in split-button
67b0ed4 
Refs: #6725
anicyne added a commit that referenced this issue Aug 14, 2024
@anicyne
fix: correct popover style in split-button
8eae1ca 
Refs: #6725
anicyne added a commit that referenced this issue Aug 14, 2024
@anicyne
fix: correct popover style in split-button
d7748b0 
Refs: #6725
anicyne added a commit that referenced this issue Aug 14, 2024
@anicyne
fix: correct popover style in split-button
5978df8 
Refs: #6725
anicyne added a commit that referenced this issue Aug 15, 2024
@anicyne
Add e2e tests fpr split-button ans popover components
50627bb 
Refs: #6725
@sdvg sdvg self-assigned this Aug 26, 2024
@sdvg sdvg moved this from 🔍 Review to 🏗 In progress in KoliBri Board Aug 26, 2024
@laske185
Copy link
Contributor Author

E2E-Tests werden separat erstellt. Zum Test für dieses Behavior sind sie nicht geeignet, da es ein visuelles Problem ist.

sdvg added a commit that referenced this issue Aug 27, 2024
@sdvg
Change Popover host classname and apply some mild refactoring
3026d33 
Refs: #6725
sdvg added a commit that referenced this issue Aug 27, 2024
@sdvg
Unify e2e test descriptions
a114a59 
Refs: #6725
sdvg added a commit that referenced this issue Aug 27, 2024
@sdvg
Refactory e2e tests
7213f37 
Refs: #6725
@sdvg sdvg moved this from 🏗 In progress to 🔍 Review in KoliBri Board Aug 27, 2024
sdvg added a commit that referenced this issue Aug 27, 2024
@sdvg
Update test
8b2f7e3 
Refs: #6725
@sdvg sdvg removed their assignment Aug 29, 2024
Makko74 added a commit that referenced this issue Sep 3, 2024
@Makko74
add popover onclose event
5c2e74c 
Refs: #6725
Makko74 added a commit that referenced this issue Sep 3, 2024
@Makko74
test remove stopPropagation
6d915c8 
Refs: #6725
Makko74 added a commit that referenced this issue Sep 3, 2024
@Makko74
fix format
d9dc09a 
Refs: #6725
Makko74 added a commit that referenced this issue Sep 3, 2024
@Makko74
closePopup Function with example
4bba9a9 
Refs: #6725
Makko74 added a commit that referenced this issue Sep 3, 2024
@Makko74
clean basic example
fd6ef28 
Refs: #6725
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anicyne anicyne

@Makko74 Makko74

Labels
bug Something isn't working
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace dropdown with kolPopoverWc in Split-Button public-ui/kolibri
4 participants
@sdvg @laske185 @anicyne @Makko74