Replace kolSelect with split button in pagination #6721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify Draft Deployment |
This was
unlinked from
issues
Aug 12, 2024
Refs: #4646
Makko74
force-pushed
the
4646-split-button-pagination
branch
from
0ce91e8 to
be54d70
Compare
Refs: #4646
…646-split-button-pagination
anicyne
force-pushed
the
4646-split-button-pagination
branch
from
36d49b3 to
903292d
Compare
anicyne
force-pushed
the
4646-split-button-pagination
branch
from
3611eb1 to
5c00bcd
Compare
sdvg
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Martin und ich haben das Feature einmal zusammen durchgeschaut. Sieht schon vielversprechend aus, folgende Punkte wollten wir vor einem detaillierten Review schon einmal weiter geben:
- Die interne Komponente bzw. Render Function sollte bitte
InternalMenu(ohne Kol) heißen, um Verwechslungen mit Stencil-Komponenten auszuschließen und der bestehenden Konvention zu folgen. - Für die einzelnen Menupunkte sollte ein KolButtonWc verwendet werden. (Das
ul > liaußenherum soll bleiben.) - Die Barrierefreiheit soll noch sichergestellt werden. Echte Button-Element Elemente sollten hier bereits helfen.
- Die Tastatursteuerung soll ermöglicht werden. Aktuell ist es nicht möglich, nach dem Aktivieren des Menus, den Fokus mit der Tastatur auf eines der Menu-Elemente zu verschieben.
…646-split-button-pagination
deleonio
force-pushed
the
develop
branch
2 times, most recently
from
2ea3a3d to
f9ccd2c
Compare
deleonio
force-pushed
the
develop
branch
2 times, most recently
from
91df132 to
9fc4e28
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #4646