Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dropdown with kolPopoverWc in Split-Button #6726

Merged
merged 17 commits into from
Sep 5, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Aug 12, 2024

Refs: #6725

@anicyne anicyne marked this pull request as draft August 12, 2024 14:57
@anicyne anicyne linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Aug 12, 2024

@anicyne anicyne marked this pull request as ready for review August 13, 2024 07:56
@anicyne anicyne force-pushed the 6725-fix-dropdown-clipping-shadow-dom branch 2 times, most recently from 8eae1ca to d7748b0 Compare August 14, 2024 10:43
@anicyne anicyne force-pushed the 6725-fix-dropdown-clipping-shadow-dom branch from d7748b0 to 5978df8 Compare August 14, 2024 11:34
@laske185
Copy link
Contributor

Bitte einen playwright Test in components-Projekt schreiben. Als Vorlage kannst du dir den Test im Abbr anschauen: packages\components\src\components\abbr\abbr.e2e.ts

sdvg added 5 commits August 26, 2024 15:47
…dropdown-clipping-shadow-dom

* 'develop' of github.com:public-ui/kolibri:
  Remove ID attribute from associated form fields
  Revert change
  Update Readme files
  Update all snapshots$ $ Refs: #6341
  chore: remove branch param
  fix: format
  Set default spinner color to black
  remove duplicate ids
  aside scrollable
  fix format
  changed color danger button
  Correct capitalization
  translate property names
  Example with font icons in the table
  Update all snapshots$ $ Refs: #6705
  Adjusted code based on review
  Update all snapshots$ $ Refs: #6705
  Translate all examples into English.
  translate examples to english
…dropdown-clipping-shadow-dom

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #6455
  fix: adjusted code based on review
  fix: adjusted code based on review
  Update all snapshots$ $ Refs: #6455
  Add more option descriptions to sample
  fix format error
  fix format errors
  Update all snapshots$ $ Refs: #6455
  Translate input-radio labels and options to English.
  Fix input-radio test
  Update all snapshots$ $ Refs: #6455
  Update input-radio with hint and description
@sdvg sdvg requested a review from laske185 August 27, 2024 07:47
Copy link
Contributor

@laske185 laske185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open-State ist nicht immer synchron:

  1. Splitbutton-Popover öffnen
  2. Mit der Maus daneben klicken -> Popover geht zu
  3. Auf den Pfeil des Splitbuttons mit der Maus gehen: Tooltip: "Hide options" - FEHLER
    image
  4. Auf Pfeil klicken -> Tooltip ändert sich in "Show options"
  5. Popover geht nicht auf - Fehler

@deleonio
Copy link
Contributor

Hi @Makko74, bitte übernimm diese Aufgabe. Danke Dir

@laske185 laske185 merged commit 41538a9 into develop Sep 5, 2024
5 checks passed
@laske185 laske185 deleted the 6725-fix-dropdown-clipping-shadow-dom branch September 5, 2024 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown am Split-Button wird abgeschnitten
5 participants