-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Zalasr #201
Adding Zalasr #201
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 3 3
Lines 642 642
=======================================
Hits 596 596
Misses 46 46 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I get the strategy, but I can guarantee it'll cause some confusion :-) Let's see if it works out in Spike, Binutils, etc. |
…` for the load-acquire byte (so `lb.aq` and `lb.aqrl`), I'm not sure that will work but it passes the tests here.
…e confusion hopefully
I've updated it so it now uses |
Thanks, Brendan. I’ll take a look at the Spike PR later this week. |
…t for store-releasee
Thinking about this some more, maybe consider adding back the |
Hmm, I think that will still have the confusion you mentioned. I'm also worried that people might choose to ignore the acquire bit for load-acquire, which would ruin compatibility for a future load-release. |
Fair enough. Implementers are obviously still free to do what they will with a reserved encoding. |
Adding load-acquire/store-release. Note they are written here as
lb.
for the load-acquire byte (solb.aq
andlb.aqrl
), I'm not sure that will work but it passes the tests here.