Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant keyword to load_robot_description #62

Closed
stephane-caron opened this issue Mar 26, 2024 · 3 comments
Closed

Add variant keyword to load_robot_description #62

stephane-caron opened this issue Mar 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@stephane-caron
Copy link
Member

Some descriptions have variants (like the "left" and "right" versions of the Allegro hand) that are currently only available when importing submodules. We could add a variant keyword argument to load_robot_description so that users can access it from there as well.

@stephane-caron stephane-caron added the enhancement New feature or request label Mar 26, 2024
@kevinzakka
Copy link
Contributor

Also useful for loading end-effector-less versions of a robot (e.g. Panda, xArm7) which ship with an end-effector.

@lvjonok
Copy link
Contributor

lvjonok commented Aug 4, 2024

I'd like to propose another feature request. Since Pinocchio v3.0.0, it's possible to use MJCF to create models. However, the Pinocchio loader in robot_descriptions currently utilizes the buildFromURDF method.

Do you think this could be better addressed using a variant keyword, or should we handle it with an if-statement to check whether module.MJCF_PATH or module.URDF_PATH is available?

@stephane-caron
Copy link
Member Author

Thanks for proposing this. I'd say we separate variants (e.g. left-handed, right-handed, with/without end-effector, etc., of a given robot) from formats (URDF/MJCF) for now. We can then go for your second proposal #101.

@robot-descriptions robot-descriptions locked and limited conversation to collaborators Aug 6, 2024
@stephane-caron stephane-caron converted this issue into discussion #102 Aug 6, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants