Improve performance

[olivroy]

Summary

I noticed that many operations were performed more than once unnecessarily.

This PR aims to reduce this duplication.

It is not a perfect solution but it is the one that respects more the current structure.

I notice a speedup 690 ms -> 580 ms

Related GitHub Issues and PRs

• Ref: Improve performance somewhat  #15

[rich-iannone]

Thank you! As with the other projects, please add yourself to the DESCRIPTION as your contributions are valuable!

[olivroy]

Thanks! I will stop it there for now. But I see about +30-50% performance improvement for the base fmt_datetime() from gt. Less operations are performed unnecessarily which greatly improves speed! As mentioned in a few places, it would be great to vectorize somehow, but the date-time formatting is quite comprehensive and we may simply want to branch out to simpler functions for the most trivial cases and keep {bigD} structure otherwise mostly untouched, except for the changes I propose here.

[olivroy]

Oops, just ran gt tests and discovered a slight regression. Will add test + fix soon

All good now!

Also, if possible a codecov token would be great to be able to track coverage if needed :)

Currently on main

This PR: (apparently reduced coverage even though I added a test that covers new stuff)

[rich-iannone]

LGTM!