Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance #16

Merged
merged 11 commits into from
Dec 8, 2024
Merged

Improve performance #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b844db4
Use the `%||%` helper + simple refactor
olivroy Dec 6, 2024
ff6f79c
Use new internal structure to avoid duplicate calculations
olivroy Dec 6, 2024
6fbc9db
Move dt_* helpers to new file dt_replace.R
olivroy Dec 6, 2024
5ffee55
Refactor code into function `dt_replace()` + add basic test to displa…
olivroy Dec 6, 2024
162fb8a
Migrate other calculations to the new method and use sub() instead of…
olivroy Dec 6, 2024
e84083f
more transition
olivroy Dec 6, 2024
2d5e462
continue
olivroy Dec 6, 2024
f0d2764
Some tweaks + add Olivier to DESCRIPTION
olivroy Dec 6, 2024
91422ef
Add failing test
olivroy Dec 6, 2024
d48fab4
Fix subsetting and test
olivroy Dec 6, 2024
18c4107
add 2 more tests
olivroy Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ Description: Format dates and times flexibly and to whichever locales
formatting patterns based on date/time skeleton formats and standardized
date/time formats with varying specificity.
Authors@R: c(
person("Richard", "Iannone", , "rich@posit.co", c("aut", "cre"),
person("Richard", "Iannone", , "rich@posit.co", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-3925-190X")),
person("Olivier", "Roy", role = "ctb"),
person("Posit Software, PBC", role = c("cph", "fnd"))
)
)
License: MIT + file LICENSE
URL: https://rstudio.github.io/bigD/, https://github.com/rstudio/bigD
BugReports: https://github.com/rstudio/bigD/issues
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# bigD (development version)

* Introduced performance improvements (@olivroy, #15, #16).

* Internal functions `dt_MM()`, `dt_yyy()` and friends are no longer used, as we
use a new internal structure to avoid duplicate calculations

# bigD 0.3.0

* The locale's territory is now better resolved for week in month calculations.
Expand Down
Loading
Loading