SD-98474 | [Madeira Madeira] Custom Identifier Improvement #1911
Conversation
|
Hi @emreisik95 thanks for the PR. I'll schedule for review. |
| export const custom_identifiers: InputField = { | ||
| label: 'Custom Identifiers', | ||
| type: 'object', | ||
| description: 'You can select your custom identifiers for the event.', |
There was a problem hiding this comment.
hi @emreisik95.
2 questions:
-
Should we default the UI to display key:value pairs?
defaultObjectUI: 'keyvalue' -
Should we make the description a little more useful? Are there specific types of Custom Identifiers the user should know about? How should the user know what to place in this field? Can you provide an example or link to a doc?
There was a problem hiding this comment.
Yes, it should be default key:value pairs, we are accepting it as key:value. Also, it should be undefined if partner won't use it.
For the second question, I'll align with our PM's and answer.
|
Hi @emreisik95 - I reviewed the PR. Looks good. Just one minor item pointed out. Please let me know if it's something you want to change or not? |
We can keep continue like this. Thanks for your review. |
|
hi @emreisik95 PR deployed |
Thanks a lot, we are checking. |
Partners can add custom identifiers to their payload. Just new field added.
Testing
We matched the custom identifiers and sent it to our side, we checked we are getting data correctly.