-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD-98474 | [Madeira Madeira] Custom Identifier Improvement #1911
Changes from all commits
e12bf4a
063fd54
8ae01a2
71f4614
f856b57
2ccb604
d3821db
70f0e86
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @emreisik95.
2 questions:
Should we default the UI to display key:value pairs?
defaultObjectUI: 'keyvalue'
Should we make the description a little more useful? Are there specific types of Custom Identifiers the user should know about? How should the user know what to place in this field? Can you provide an example or link to a doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be default key:value pairs, we are accepting it as key:value. Also, it should be undefined if partner won't use it.
For the second question, I'll align with our PM's and answer.