Build: Always cleanup Verdaccio ports before running registry

[yannbf]

Closes #

What I did

For years we had issues in the task command where the run-registry task would fail with:

🎬 starting verdaccio (this takes ±5 seconds, so be patient)
info --- plugin successfully loaded: verdaccio-auth-memory
node:events:496
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE: address already in use :::6001
    at Server.setupListenHandle [as _listen2] (node:net:1907:16)
    at listenInCluster (node:net:1964:12)
    at Server.listen (node:net:2066:7)
    at /Users/yannbraga/open-source/storybook/scripts/run-registry.ts:67:11
    at new Promise (<anonymous>)
    at startVerdaccio (/Users/yannbraga/open-source/storybook/scripts/run-registry.ts:38:3)
    at run (/Users/yannbraga/open-source/storybook/scripts/run-registry.ts:175:3)

This PR fixes that issue by killing the processes in the verdaccio ports before running the registry task

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Added port cleanup functionality to prevent Verdaccio server hanging issues by automatically killing processes on specific ports before starting the registry server.

• Added scripts/utils/kill-port.ts utility to handle process termination on both Windows and Unix systems
• Modified scripts/run-registry.ts to cleanup ports 6001 and 6002 before starting Verdaccio
• Added error handling to ensure port cleanup happens even when registry startup fails
• Extracted hardcoded port numbers into constants for better maintainability

[greptile-apps]

_{2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: error handling chain could fail silently if rm() or cleanupVerdaccioProcesses() rejects - should wrap in try/catch

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aefde6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.

[yannbf]

This needs extra work unfortunately