-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Always cleanup Verdaccio ports before running registry #30023
Open
yannbf
wants to merge
2
commits into
next
Choose a base branch
from
yann/fix-verdaccio-hanging
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
// eslint-disable-next-line depend/ban-dependencies | ||
import { execa } from 'execa'; | ||
|
||
/** | ||
* This code is derived from the library `kill-port` by Tiaan du Plessis. Original repository: | ||
* https://github.com/tiaanduplessis/kill-port | ||
* | ||
* The MIT License (MIT) | ||
* | ||
* Copyright (c) Tiaan du Plessis | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy of this software and | ||
* associated documentation files (the "Software"), to deal in the Software without restriction, | ||
* including without limitation the rights to use, copy, modify, merge, publish, distribute, | ||
* sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all copies or | ||
* substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT | ||
* NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
*/ | ||
const killProcessInPort = async (port: number, method: 'tcp' | 'udp' = 'tcp') => { | ||
if (!port || isNaN(port)) { | ||
throw new Error('Invalid argument provided for port'); | ||
} | ||
let args: string[] = []; | ||
let command: string; | ||
|
||
if (process.platform === 'win32') { | ||
try { | ||
const { stdout } = await execa('netstat', ['-nao']); | ||
|
||
if (!stdout) { | ||
return; | ||
} | ||
yannbf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const lines = stdout.split('\n'); | ||
const lineWithLocalPortRegEx = new RegExp(`^ *${method.toUpperCase()} *[^ ]*:${port}`, 'gm'); | ||
const linesWithLocalPort = lines.filter((line) => line.match(lineWithLocalPortRegEx)); | ||
|
||
const pids = linesWithLocalPort.reduce<string[]>((acc, line) => { | ||
const match = line.match(/\d+/gm); | ||
if (match && match[0] && !acc.includes(match[0])) { | ||
acc.push(match[0]); | ||
} | ||
return acc; | ||
}, []); | ||
|
||
if (pids.length > 0) { | ||
args = ['/F', ...pids.flatMap((pid) => ['/PID', pid])]; | ||
command = 'TaskKill'; | ||
} | ||
} catch (error) { | ||
throw new Error(`Failed to detect process on port ${port}: ${(error as Error).message}`); | ||
} | ||
} else { | ||
const protocol = method === 'udp' ? 'udp' : 'tcp'; | ||
args = [ | ||
'-c', | ||
`lsof -i ${protocol}:${port} | grep ${method === 'udp' ? 'UDP' : 'LISTEN'} | awk '{print $2}' | xargs kill -9`, | ||
yannbf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
]; | ||
command = 'sh'; | ||
} | ||
|
||
try { | ||
if (command) { | ||
await execa(command, args); | ||
} else { | ||
throw new Error('No command to kill process found'); | ||
} | ||
} catch (error: any) { | ||
yannbf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (!error.message.includes('No such process')) { | ||
console.error(`Failed to kill process on port ${port}`); | ||
throw error; | ||
} | ||
} | ||
}; | ||
|
||
export const killPort = async (ports: number | number[], method: 'tcp' | 'udp' = 'tcp') => { | ||
const allPorts = Array.isArray(ports) ? ports : [ports]; | ||
|
||
console.log(`🚮 cleaning up process in ports: ${allPorts.join(', ')}`); | ||
await Promise.all(allPorts.map((port) => killProcessInPort(port, method))); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: error handling chain could fail silently if rm() or cleanupVerdaccioProcesses() rejects - should wrap in try/catch