-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.5.0-beta.7 #30145
Conversation
Addon Test: Context menu updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Removing this component entirely could break functionality if it's still being imported elsewhere in the codebase. Ensure all references to ContextMenuItem are also removed or replaced appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: This component is being completely removed. Verify that all references to this Title component have been properly handled in other files that may have imported it, particularly TestProviderRender.tsx and ContextMenuItem.tsx which are also being modified in this PR.
state.progress?.percentageCompleted ?? | ||
(state.details as any)?.buildProgressPercentage | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Unsafe type casting to any. Consider defining proper type for details object that includes buildProgressPercentage
const toggleButton = await screen.getByLabelText(/Expand/); | ||
await userEvent.click(toggleButton); | ||
await fireEvent.click(toggleButton); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: fireEvent is less realistic than userEvent for simulating real user interactions. Consider keeping userEvent for better test coverage.
Vue: Extend sourceDecorator to support v-bind and nested keys in slots
source-loader: Fix parser imports from prettier
cd33479
to
115ad09
Compare
115ad09
to
3857e1e
Compare
View your CI Pipeline Execution ↗ for commit 3857e1e.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 7 | 7 | 0 |
Self size | 1.89 MB | 1.89 MB | 0 B |
Dependency size | 10.70 MB | 10.74 MB | 🚨 +43 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 393 | 393 | 0 |
Self size | 496 KB | 496 KB | 0 B |
Dependency size | 77.68 MB | 77.72 MB | 🚨 +45 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 273 | 273 | 0 |
Self size | 612 KB | 612 KB | 0 B |
Dependency size | 67.58 MB | 67.62 MB | 🚨 +44 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/source-loader
Before | After | Difference | |
---|---|---|---|
Dependency count | 5 | 5 | 0 |
Self size | 41 KB | 41 KB | 🎉 -84 B 🎉 |
Dependency size | 10.64 MB | 10.68 MB | 🚨 +43 KB 🚨 |
Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
8.5.0-beta.6
to8.5.0-beta.7
.Once this pull request is merged, it will trigger a new release of version
8.5.0-beta.7
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-beta.7