Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.5.0-beta.7 #30145

Merged
merged 26 commits into from
Dec 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 27, 2024

This is an automated pull request that bumps the version from 8.5.0-beta.6 to 8.5.0-beta.7.
Once this pull request is merged, it will trigger a new release of version 8.5.0-beta.7.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Storysource Addon: Fix source-loader prettier imports #29669
  • 🐛 Bug: Vue: Extend sourceDecorator to support v-bind and nested keys in slots #28787
  • 🐛 Bug: Addon Test: Context menu updates #30107

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.5.0-beta.7

  • Addon Test: Context menu updates - #30107, thanks @ghengeveld!
  • Storysource Addon: Fix source-loader prettier imports - #29669, thanks @slax57!
  • Vue: Extend sourceDecorator to support v-bind and nested keys in slots - #28787, thanks @JoCa96!

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Dec 27, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removing this component entirely could break functionality if it's still being imported elsewhere in the codebase. Ensure all references to ContextMenuItem are also removed or replaced appropriately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This component is being completely removed. Verify that all references to this Title component have been properly handled in other files that may have imported it, particularly TestProviderRender.tsx and ContextMenuItem.tsx which are also being modified in this PR.

Comment on lines +102 to +104
state.progress?.percentageCompleted ??
(state.details as any)?.buildProgressPercentage
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Unsafe type casting to any. Consider defining proper type for details object that includes buildProgressPercentage

Comment on lines 157 to +158
const toggleButton = await screen.getByLabelText(/Expand/);
await userEvent.click(toggleButton);
await fireEvent.click(toggleButton);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: fireEvent is less realistic than userEvent for simulating real user interactions. Consider keeping userEvent for better test coverage.

Vue: Extend sourceDecorator to support v-bind and nested keys in slots
source-loader: Fix parser imports from prettier
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-beta.6 branch from cd33479 to 115ad09 Compare December 27, 2024 10:35
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-beta.6 branch from 115ad09 to 3857e1e Compare December 27, 2024 11:49
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Dec 27, 2024
Copy link

nx-cloud bot commented Dec 27, 2024

View your CI Pipeline Execution ↗ for commit 3857e1e.

Command Status Duration Result
nx affected -t check -c production --parallel=7 ✅ Succeeded <1s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-27 14:26:23 UTC

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: 3857e1e, ran on 27 December 2024 at 14:34:44 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-storysource

Before After Difference
Dependency count 7 7 0
Self size 1.89 MB 1.89 MB 0 B
Dependency size 10.70 MB 10.74 MB 🚨 +43 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 393 393 0
Self size 496 KB 496 KB 0 B
Dependency size 77.68 MB 77.72 MB 🚨 +45 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 273 273 0
Self size 612 KB 612 KB 0 B
Dependency size 67.58 MB 67.62 MB 🚨 +44 KB 🚨
Bundle Size Analyzer Link Link

@storybook/source-loader

Before After Difference
Dependency count 5 5 0
Self size 41 KB 41 KB 🎉 -84 B 🎉
Dependency size 10.64 MB 10.68 MB 🚨 +43 KB 🚨
Bundle Size Analyzer Link Link

@shilman shilman merged commit da74d3c into next-release Dec 27, 2024
106 of 112 checks passed
@shilman shilman deleted the version-non-patch-from-8.5.0-beta.6 branch December 27, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants