Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.5.0-beta.7 #30145

Merged
merged 26 commits into from
Dec 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
7c85a39
extend vue3 sourceDecorator to support v-bind and nested keys
JoCa96 Aug 2, 2024
ea9e195
extended TemplateSlots example
JoCa96 Aug 2, 2024
6a151f9
Merge branch 'next' of https://github.com/storybookjs/storybook into …
JoCa96 Aug 2, 2024
da1cb91
Merge branch 'next' into next
chakAs3 Aug 8, 2024
a7d6a26
Merge branch 'next' into next
kasperpeulen Sep 24, 2024
9dc9ac2
Merge branch 'next' of https://github.com/storybookjs/storybook into …
JoCa96 Sep 24, 2024
f360c27
fix lint issues
JoCa96 Sep 24, 2024
c786b6d
source-loader: Fix parser imports from prettier
slax57 Nov 20, 2024
99ac238
Merge branch 'next' into fix-source-loader-prettier-import
slax57 Nov 20, 2024
949aa12
Merge branch 'next' into next
JoCa96 Dec 11, 2024
4c7ca98
Merge branch 'next' into fix-source-loader-prettier-import
slax57 Dec 18, 2024
c7f3af4
Disallow editing test provider config from context menu
ghengeveld Dec 18, 2024
8d5cc0e
Reorder test provider options
ghengeveld Dec 19, 2024
32a2bf2
Merge branch 'next' into context-menu-updates
ghengeveld Dec 19, 2024
f30da26
Show tooltip note on buttons without label
ghengeveld Dec 19, 2024
fb726a6
Merge branch 'next' into context-menu-updates
ghengeveld Dec 20, 2024
6aabe37
Refactor and improve title and description, and make pending status d…
ghengeveld Dec 20, 2024
55240ff
Update tests
ghengeveld Dec 23, 2024
0321843
Merge branch 'next' into context-menu-updates
ghengeveld Dec 23, 2024
a0702ec
Use fireEvent rather than userEvent
ghengeveld Dec 23, 2024
b82d3b0
Update E2E tests
ghengeveld Dec 23, 2024
2c88aa2
Merge branch 'next' into next
yannbf Dec 24, 2024
413c45e
Merge pull request #30107 from storybookjs/context-menu-updates
ghengeveld Dec 27, 2024
82777d7
Merge pull request #28787 from JoCa96/next
kasperpeulen Dec 27, 2024
3b18e74
Merge pull request #29669 from slax57/fix-source-loader-prettier-import
kasperpeulen Dec 27, 2024
3857e1e
Write changelog for 8.5.0-beta.7 [skip ci]
storybook-bot Dec 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.prerelease.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 8.5.0-beta.7

- Addon Test: Context menu updates - [#30107](https://github.com/storybookjs/storybook/pull/30107), thanks @ghengeveld!
- Storysource Addon: Fix source-loader prettier imports - [#29669](https://github.com/storybookjs/storybook/pull/29669), thanks @slax57!
- Vue: Extend sourceDecorator to support v-bind and nested keys in slots - [#28787](https://github.com/storybookjs/storybook/pull/28787), thanks @JoCa96!

## 8.5.0-beta.6

- Addon Test: Always use installed version of vitest - [#30134](https://github.com/storybookjs/storybook/pull/30134), thanks @kasperpeulen!
Expand Down
2 changes: 1 addition & 1 deletion code/addons/docs/docs/props-tables.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Storybook Docs automatically generates props tables for components in supported

## Usage

For framework-specific setup instructions, see the framework's README: [React](../react/README.md), [Vue3 ](../vue3/README.md), [Angular](../angular/README.md), [Web Components](../web-components/README.md), [Ember](../ember/README.md).
For framework-specific setup instructions, see the framework's README: [React](../react/README.md), [Vue3](../vue3/README.md), [Angular](../angular/README.md), [Web Components](../web-components/README.md), [Ember](../ember/README.md).

### DocsPage

Expand Down
76 changes: 0 additions & 76 deletions code/addons/test/src/components/ContextMenuItem.tsx

This file was deleted.

21 changes: 13 additions & 8 deletions code/addons/test/src/components/Description.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Link as LinkComponent } from 'storybook/internal/components';
import { type TestProviderConfig, type TestProviderState } from 'storybook/internal/core-events';
import { styled } from 'storybook/internal/theming';

import type { TestResultResult } from '../node/reporter';
import { GlobalErrorContext } from './GlobalErrorModal';
import { RelativeTime } from './RelativeTime';

Expand All @@ -19,11 +20,13 @@ const PositiveText = styled.span(({ theme }) => ({
color: theme.color.positiveText,
}));

interface DescriptionProps extends ComponentProps<typeof Wrapper> {
interface DescriptionProps extends Omit<ComponentProps<typeof Wrapper>, 'results'> {
state: TestProviderConfig & TestProviderState;
entryId?: string;
results?: TestResultResult[];
}

export function Description({ state, ...props }: DescriptionProps) {
export function Description({ state, entryId, results, ...props }: DescriptionProps) {
const isMounted = React.useRef(false);
const [isUpdated, setUpdated] = React.useState(false);
const { setModalOpen } = React.useContext(GlobalErrorContext);
Expand All @@ -48,15 +51,17 @@ export function Description({ state, ...props }: DescriptionProps) {
description = state.progress
? `Testing... ${state.progress.numPassedTests}/${state.progress.numTotalTests}`
: 'Starting...';
} else if (entryId && results?.length) {
description = `Ran ${results.length} ${results.length === 1 ? 'test' : 'tests'}`;
} else if (state.failed && !errorMessage) {
description = 'Failed';
} else if (state.crashed || (state.failed && errorMessage)) {
description = (
<>
<LinkComponent isButton onClick={() => setModalOpen(true)}>
{state.error?.name || 'View full error'}
</LinkComponent>
</>
description = setModalOpen ? (
<LinkComponent isButton onClick={() => setModalOpen(true)}>
{state.error?.name || 'View full error'}
</LinkComponent>
) : (
state.error?.name || 'Failed'
);
} else if (state.progress?.finishedAt) {
description = (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export const Editing: Story = {
play: async ({ canvasElement }) => {
const screen = within(canvasElement);

screen.getByLabelText(/Open settings/).click();
screen.getByLabelText(/Show settings/).click();
},
};

Expand Down
Loading
Loading