Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ignore-expo cli option #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

killerchip
Copy link

This option forces ignoring expo projects and treats them as bare-workflow/ejected projects. It helps manually overcome issues when react-native-version falselsy identifies expo presence.

Work-around for issue #105

This option forces ignoring expo projects and treats them as bare-workflow/ejected projects. It helps manually overcome issues when react-native-version falselsy identifies expo presence.
Copy link

@bayoremit bayoremit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful

@LuisRodriguezLD
Copy link

This is gold, can we merge this?

@MidknightMan
Copy link

+1 a merge would be sensational

@scriptspry
Copy link

I am afraid this may not be merge ready yet. Even after ejecting expo project, the expo key in app.json would be used by some expo modules that started to support even bare flow like expo-updates.

So this needs logic fix as well. Or, might need running it first with out the flag and then with flag? (have not thought this through)

@agape-apps
Copy link

agape-apps commented Aug 7, 2021

I am currently using this PR via patch-package, while the maintainers take their time to decide if this or the other PR (Adds two CLI options: --is-bare-expo-workflow and --is-self-hosting-bundles ) has the superior logic.

The current Expo bare-workflow bug needs a "logic fix" and it has been more than a year without such a fix. Either of these two solutions seem to do the job.

patch-package lets app authors instantly make and keep fixes to npm dependencies. It's a vital band-aid for those of us living on the bleeding edge.

# fix a bug in one of your dependencies
vim node_modules/some-package/brokenFile.js
# run patch-package to create a .patch file
npx patch-package some-package
# commit the patch file to share the fix with your team
git add patches/some-package+3.14.15.patch
git commit -m "fix brokenFile.js in some-package"

Patches created by patch-package are automatically and gracefully applied when you use npm(>=5) or yarn.
No more waiting around for pull requests to be merged and published. No more forking repos just to fix that one tiny thing preventing your app from working.

@manuelbieh
Copy link

Would also love to have this option. Any news on that? 🙂

@saladestomateoignon
Copy link

Hello it would be cool to have this option indeed. Any news about it :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants