-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--ignore-expo cli option #150
base: master
Are you sure you want to change the base?
Conversation
This option forces ignoring expo projects and treats them as bare-workflow/ejected projects. It helps manually overcome issues when react-native-version falselsy identifies expo presence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful
This is gold, can we merge this? |
+1 a merge would be sensational |
I am afraid this may not be merge ready yet. Even after ejecting expo project, the expo key in app.json would be used by some expo modules that started to support even bare flow like expo-updates. So this needs logic fix as well. Or, might need running it first with out the flag and then with flag? (have not thought this through) |
I am currently using this PR via patch-package, while the maintainers take their time to decide if this or the other PR (Adds two CLI options: --is-bare-expo-workflow and --is-self-hosting-bundles ) has the superior logic. The current Expo bare-workflow bug needs a "logic fix" and it has been more than a year without such a fix. Either of these two solutions seem to do the job.
|
Would also love to have this option. Any news on that? 🙂 |
Hello it would be cool to have this option indeed. Any news about it :) ? |
This option forces ignoring expo projects and treats them as bare-workflow/ejected projects. It helps manually overcome issues when react-native-version falselsy identifies expo presence.
Work-around for issue #105