-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds two CLI options: --is-bare-expo-workflow and --is-self-hosting-bundles #243
base: master
Are you sure you want to change the base?
Conversation
This lib thinks we're an "expo" app just because we have the package + an app.json, which is outdated now. This let's us write the app.json, android, and iOS all together. It also will update the versions of our postExport hooks, if they exist.
1. --is-bare-expo-workflow Bare workflow expo apps want to update *everything*. This will update the app.json values and the /android and the /ios values. 2. --is-self-hosting-bundles This one is a bit more esoteric, but it's meant for bare workflow apps using sentry-expo to upload their sourcemaps in a postExport hook, where it's essential to keep the release/dist versions align with the build/release versions. If it's passed in, it will look in the hooks inside the app.json file to update these values as needed.
Thoughts :) ? |
@stovmascript can we get this merged, urgently need this for my bare flow react-native project. |
Any updates on this? |
Is there any progress on this feature? I had to patch it locally as otherwise react-native-version does not work with Expo Bare Workflow. |
This looks great. Can we have it merged? |
I am currently using the other PR (--ignore-expo cli option by killerchip · Pull Request #150) via patch-package, while the maintainers take time to decide if the other PR or this PR has the superior logic. The current Expo bare-workflow bug needs a "logic fix" and it has been more than a year without such a fix. Either of these two solutions seem to do the job.
|
There is anyone maintaining this repo? |
@stovmascript do you have any blockers with merging this pr? if so, I think, a lot of us can help you with solving problems |
I've got a semi-specific use case for a Bare Workflow Expo app, and thought I'd try to upstream these changes in to see if others may also find it useful.
This adds two new CLI options:
--is-bare-expo-workflow
Bare workflow expo apps potentially want to update everything. This includes the app.json, the ios stuff and the android stuff. Currently, this library only supports updating the app.json vs. native code depending on it's awkward definition of an "expo" app. Some of the pathways in the library don't allow both, where this argument will go out of it's way to update both.
--is-self-hosting-bundles
This one is a bit more esoteric, but it's meant for bare workflow apps using sentry-expo to upload their source-maps in a postExport hook, where it's essential to keep the release/dist versions aligned with the build/release versions. If it's passed in, it will look in the hooks inside the app.json file to update these values as needed to their newly bumped versions.
Combined, these two flags allow us to have a workflow where we can run
npm version patch
, which then updates the package.json, the app.json, the /android values, the /ios values, as well as updates our postExport hook in the app.json.Thanks for the library! Hope you'll consider these changes. All tests still pass.